I checked you pr look good to me @Roger
Le mer. 11 mai 2022 à 15:35, Roger Riggs a écrit :
> On Wed, 11 May 2022 13:27:38 GMT, Adam Sotona wrote:
>
> >> That's good to know. I think the tricky part is mostly about keeping
> track of all these disabled warnings, so they are not kept around
On Wed, 11 May 2022 13:31:16 GMT, Roger Riggs wrote:
>> Thanks for quick reaction.
>> I'll keep my eyes on this race of patches and update this pull request
>> accordingly or create a new PR.
>
> I put out a PR for java.base, but thought I'd wait until the javac fixe were
> pushed before
On Wed, 11 May 2022 13:27:38 GMT, Adam Sotona wrote:
>> That's good to know. I think the tricky part is mostly about keeping track
>> of all these disabled warnings, so they are not kept around longer than
>> necessary. And that needs coordination with all the subtasks of the umbrella
>>
On Wed, 11 May 2022 13:10:10 GMT, Magnus Ihse Bursie wrote:
>> I agree, but if it doesn't happen, I can follow up with a separate PR where
>> I remove the disablement.
>
> That's good to know. I think the tricky part is mostly about keeping track of
> all these disabled warnings, so they are
On Wed, 11 May 2022 13:05:45 GMT, Erik Gahlin wrote:
>> make/modules/jdk.jfr/Java.gmk line 26:
>>
>>> 24: #
>>> 25:
>>> 26: DISABLED_WARNINGS_java += exports lossy-conversions
>>
>> Note that with the fix of JDK-8286392 (and JDK-8286396) the
>> `lossy-conversions` warning should not be
On Wed, 11 May 2022 12:59:49 GMT, Magnus Ihse Bursie wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8244681: Add a warning for possibly lossy conversion in compound
>> assignments
>> recommended correction of
On Wed, 11 May 2022 07:45:39 GMT, Adam Sotona wrote:
>> Please review this patch adding new lint option, **lossy-conversions**, to
>> javac to warn about type casts in compound assignments with possible lossy
>> conversions.
>>
>> The new lint warning is shown if the type of the right-hand
On Wed, 11 May 2022 07:45:39 GMT, Adam Sotona wrote:
>> Please review this patch adding new lint option, **lossy-conversions**, to
>> javac to warn about type casts in compound assignments with possible lossy
>> conversions.
>>
>> The new lint warning is shown if the type of the right-hand
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment
