Re: RFR: 8246774: Record Classes (final) implementation [v3]

2020-09-25 Thread Peter Levart
On Fri, 25 Sep 2020 02:38:01 GMT, Vicente Romero wrote: >> I have modified the `@since`: 14 -> 16 > > [CSR: Record Classes](https://bugs.openjdk.java.net/browse/JDK-8253605) Hi @vicente-romero-oracle , note that besides tests, there is also a JMH benchmark that measures the performance of recor

Re: RFR: 8246774: Record Classes (final) implementation [v3]

2020-09-24 Thread Vicente Romero
On Thu, 24 Sep 2020 15:45:22 GMT, Vicente Romero wrote: >> The classfile parser changes look good to me. > > I have modified the `@since`: 14 -> 16 [CSR: Record Classes](https://bugs.openjdk.java.net/browse/JDK-8253605) - PR: https://git.openjdk.java.net/jdk/pull/290

Re: RFR: 8246774: Record Classes (final) implementation [v6]

2020-09-24 Thread Vicente Romero
> Co-authored-by: Vicente Romero > Co-authored-by: Harold Seigel > Co-authored-by: Jonathan Gibbons > Co-authored-by: Brian Goetz > Co-authored-by: Maurizio Cimadamore > Co-authored-by: Joe Darcy > Co-authored-by: Chris Hegarty > Co-authored-by: Jan Lahoda Vicente Romero has updated the pu

Re: RFR: 8246774: Record Classes (final) implementation [v5]

2020-09-24 Thread Vicente Romero
> Co-authored-by: Vicente Romero > Co-authored-by: Harold Seigel > Co-authored-by: Jonathan Gibbons > Co-authored-by: Brian Goetz > Co-authored-by: Maurizio Cimadamore > Co-authored-by: Joe Darcy > Co-authored-by: Chris Hegarty > Co-authored-by: Jan Lahoda Vicente Romero has updated the pu

Re: RFR: 8246774: Record Classes (final) implementation [v3]

2020-09-24 Thread Vicente Romero
On Thu, 24 Sep 2020 12:23:13 GMT, Coleen Phillimore wrote: >> Vicente Romero has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Merge pull request #1 from ChrisHegarty/record-serial-tests >> >>Remove preview args from JDK tests

Re: RFR: 8246774: Record Classes (final) implementation [v4]

2020-09-24 Thread Vicente Romero
> Co-authored-by: Vicente Romero > Co-authored-by: Harold Seigel > Co-authored-by: Jonathan Gibbons > Co-authored-by: Brian Goetz > Co-authored-by: Maurizio Cimadamore > Co-authored-by: Joe Darcy > Co-authored-by: Chris Hegarty > Co-authored-by: Jan Lahoda Vicente Romero has updated the pu

Re: RFR: 8246774: Record Classes (final) implementation [v3]

2020-09-24 Thread Coleen Phillimore
On Wed, 23 Sep 2020 03:34:29 GMT, Vicente Romero wrote: >> Co-authored-by: Vicente Romero >> Co-authored-by: Harold Seigel >> Co-authored-by: Jonathan Gibbons >> Co-authored-by: Brian Goetz >> Co-authored-by: Maurizio Cimadamore >> Co-authored-by: Joe Darcy >> Co-authored-by: Chris Hegarty

Re: RFR: 8246774: Record Classes (final) implementation

2020-09-23 Thread Mandy Chung
On Thu, 24 Sep 2020 00:23:13 GMT, Mandy Chung wrote: >> @vicente-romero-oracle I noticed that we can also remove the preview args >> from the record serialization tests and >> ObjectMethodsTest. I opened a PR against the branch in your fork. You should >> be able to just merge in the changes. S

Re: RFR: 8246774: Record Classes (final) implementation

2020-09-23 Thread Alex Buckley
On 9/23/2020 5:26 PM, Mandy Chung wrote: What is the policy of `@since` release value when a preview API becomes final.I would expect `@since` should be updated from 14 to 16 because 16 is the Java SE release these APIs are added?? Yes. Per http://openjdk.java.net/jeps/12#Specifications-of

Re: RFR: 8246774: Record Classes (final) implementation

2020-09-23 Thread Mandy Chung
On Tue, 22 Sep 2020 09:49:12 GMT, Chris Hegarty wrote: >> note: I have removed from the original patch the code related to >> javax.lang.model, I will publish them in a separate PR > > @vicente-romero-oracle I noticed that we can also remove the preview args > from the record serialization test

Re: RFR: 8246774: Record Classes (final) implementation [v3]

2020-09-22 Thread Vicente Romero
> Co-authored-by: Vicente Romero > Co-authored-by: Harold Seigel > Co-authored-by: Jonathan Gibbons > Co-authored-by: Brian Goetz > Co-authored-by: Maurizio Cimadamore > Co-authored-by: Joe Darcy > Co-authored-by: Chris Hegarty > Co-authored-by: Jan Lahoda Vicente Romero has updated the pu

Re: RFR: 8246774: Record Classes (final) implementation

2020-09-22 Thread Vicente Romero
good catch Chris, thanks for the patch, Vicente On 9/22/20 5:51 AM, Chris Hegarty wrote: On Mon, 21 Sep 2020 23:21:18 GMT, Vicente Romero wrote: Hi Vicente, Please file a separate subtask for the javax.lang.model changes. This helps with the JSR 269 MR paperwork. Thanks, -Joe note: I have

Re: RFR: 8246774: Record Classes (final) implementation

2020-09-22 Thread Chris Hegarty
On Mon, 21 Sep 2020 23:21:18 GMT, Vicente Romero wrote: >> Hi Vicente, >> Please file a separate subtask for the javax.lang.model changes. This helps >> with the JSR 269 MR paperwork. >> Thanks, >> -Joe > > note: I have removed from the original patch the code related to > javax.lang.model, I w

Re: RFR: 8246774: Record Classes (final) implementation [v2]

2020-09-21 Thread Vicente Romero
> Co-authored-by: Vicente Romero > Co-authored-by: Harold Seigel > Co-authored-by: Jonathan Gibbons > Co-authored-by: Brian Goetz > Co-authored-by: Maurizio Cimadamore > Co-authored-by: Joe Darcy > Co-authored-by: Chris Hegarty > Co-authored-by: Jan Lahoda Vicente Romero has updated the pu

Re: RFR: 8246774: Record Classes (final) implementation

2020-09-21 Thread Vicente Romero
On Mon, 21 Sep 2020 21:53:05 GMT, Joe Darcy wrote: >> Please review the fix for [1]. The intention of this patch is to make >> records final removing the need to >> use --enable-preview in order to be able to include a record declaration in >> a source or for the VM to execute code >> compiled

Re: RFR: 8246774: Record Classes (final) implementation

2020-09-21 Thread Joe Darcy
On Mon, 21 Sep 2020 21:36:39 GMT, Vicente Romero wrote: >> Co-authored-by: Vicente Romero >> Co-authored-by: Harold Seigel >> Co-authored-by: Jonathan Gibbons >> Co-authored-by: Brian Goetz >> Co-authored-by: Maurizio Cimadamore >> Co-authored-by: Joe Darcy >> Co-authored-by: Chris Hegarty

Re: RFR: 8246774: Record Classes (final) implementation

2020-09-21 Thread Vicente Romero
On Mon, 21 Sep 2020 21:30:51 GMT, Vicente Romero wrote: > Co-authored-by: Vicente Romero > Co-authored-by: Harold Seigel > Co-authored-by: Jonathan Gibbons > Co-authored-by: Brian Goetz > Co-authored-by: Maurizio Cimadamore > Co-authored-by: Joe Darcy > Co-authored-by: Chris Hegarty > Co-a