On Mon, 14 Sep 2020 12:59:00 GMT, Galder Zamarreño
wrote:
>> Note that I've opened
>> [SKARA-633](https://bugs.openjdk.java.net/browse/SKARA-633) for
>> pre-population of the commit
>> message with an appropriate summary.
>
> Add release fence to ClassValueMap constructor.
>
> * Release fence
> * Release fence guarantees that cacheArray field will published with a
> non-null value.
> * Without this fix, CacheValueMap.cacheArray can sometimes be seen as null.
>
> This is a follow up to @PaulSandoz's feedback
> [here](https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068
On Mon, 14 Sep 2020 12:04:30 GMT, Severin Gehwolf wrote:
>> @galderz Now it's the other way round. Commit message the bot mentions
>> [here](https://github.com/openjdk/jdk/pull/94#issuecomment-691478179) should
>> be something like this:
>> 8251397: NPE on ClassValue.ClassValueMap.cacheArray
>>
On Mon, 14 Sep 2020 08:25:51 GMT, Severin Gehwolf wrote:
>> @galderz The PR has this synopsis `8251397: Add release fence to
>> ClassValueMap constructor`. The bug has this `8251397:
>> NPE on ClassValue.ClassValueMap.cacheArray`. @dholmes-ora asked to make them
>> matching. Let's fix that firs
On Mon, 14 Sep 2020 12:02:14 GMT, Severin Gehwolf wrote:
>> You can add what you have as synopsis now via /summary and the bot.
>
> @galderz Now it's the other way round. Commit message the bot mentions
> [here](https://github.com/openjdk/jdk/pull/94#issuecomment-691478179) should
> be something
On Mon, 14 Sep 2020 08:03:51 GMT, Galder Zamarreño
wrote:
>> Please ensure the PR title and the bug synopsis match before this in
>> integrated!
>>
>> Please DO NOT force-push updates as you lose the history of commits and
>> anyone following this cannot see what changes
>> were actually made
On Mon, 14 Sep 2020 08:24:15 GMT, Severin Gehwolf wrote:
>> Are you expecting anything else from me? @jerboaa already proposed as
>> sponsor above.
>
> @galderz The PR has this synopsis `8251397: Add release fence to
> ClassValueMap constructor`. The bug has this `8251397:
> NPE on ClassValue.C
On Mon, 14 Sep 2020 02:56:43 GMT, David Holmes wrote:
>> @galderz We'll have to wait until somebody marks your github handle as OCA
>> approved or some such :-/
>
> Please ensure the PR title and the bug synopsis match before this in
> integrated!
>
> Please DO NOT force-push updates as you lo
On Thu, 10 Sep 2020 13:29:29 GMT, Severin Gehwolf wrote:
>> Just noting here that @galderz is a Red Hat employee and should be covered
>> by the Red Hat OCA:
>> https://www.oracle.com/technical-resources/oracle-contributor-agreement.html#r
>
> @galderz We'll have to wait until somebody marks you
On Wed, 9 Sep 2020 12:35:06 GMT, Galder Zamarreño
wrote:
> * Release fence guarantees that cacheArray field will published with a
> non-null value.
> * Without this fix, CacheValueMap.cacheArray can sometimes be seen as null.
>
> This is a follow up to @PaulSandoz's feedback
> [here](https://m
On Wed, 9 Sep 2020 12:50:07 GMT, Galder Zamarreño
wrote:
>> src/java.base/share/classes/java/lang/ClassValue.java line 386:
>>
>>> 384: // since stores to the fields of ClassValueMap will
>>> not be reordered
>>> 385: // to occur after the store to the field
>>
On Wed, 9 Sep 2020 12:53:41 GMT, Galder Zamarreño
wrote:
>> Ah yes, my bad 🤦♂️
>
> Updated PR.
Now I wonder (after reading the discussion), why not
`UNSAFE.storeStoreFence()`? I am basically okay with either, given
they currently map to the same thing. But it seems that semantically only
`st
On Thu, 10 Sep 2020 10:03:53 GMT, Severin Gehwolf wrote:
>> Marked as reviewed by shade (Reviewer).
>
> Just noting here that @galderz is a Red Hat employee and should be covered by
> the Red Hat OCA:
> https://www.oracle.com/technical-resources/oracle-contributor-agreement.html#r
@galderz We'l
On Wed, 9 Sep 2020 15:13:29 GMT, Paul Sandoz wrote:
>> * Release fence guarantees that cacheArray field will published with a
>> non-null value.
>> * Without this fix, CacheValueMap.cacheArray can sometimes be seen as null.
>>
>> This is a follow up to @PaulSandoz's feedback
>> [here](https://m
On Wed, 9 Sep 2020 13:04:38 GMT, Aleksey Shipilev wrote:
>> Updated PR.
>
> Now I wonder (after reading the discussion), why not
> `UNSAFE.storeStoreFence()`? I am basically okay with either, given
> they currently map to the same thing. But it seems that semantically only
> `storeStoreFence` i
On Wed, 9 Sep 2020 12:43:20 GMT, Aleksey Shipilev wrote:
>> * Release fence guarantees that cacheArray field will published with a
>> non-null value.
>> * Without this fix, CacheValueMap.cacheArray can sometimes be seen as null.
>>
>> This is a follow up to @PaulSandoz's feedback
>> [here](http
On Thu, 10 Sep 2020 08:08:10 GMT, Aleksey Shipilev wrote:
>> * Release fence guarantees that cacheArray field will published with a
>> non-null value.
>> * Without this fix, CacheValueMap.cacheArray can sometimes be seen as null.
>>
>> This is a follow up to @PaulSandoz's feedback
>> [here](htt
On Wed, 9 Sep 2020 12:35:06 GMT, Galder Zamarreño
wrote:
> * Release fence guarantees that cacheArray field will published with a
> non-null value.
> * Without this fix, CacheValueMap.cacheArray can sometimes be seen as null.
>
> This is a follow up to @PaulSandoz's feedback
> [here](https://m
18 matches
Mail list logo
