Re: RFR: 8252537: Updated @exception with @throws [v4]

2020-09-28 Thread Roger Riggs
On Sun, 27 Sep 2020 12:46:21 GMT, Vipin Sharma wrote: >> Updated @exception with @throws for core-libs, it fixes all open sub-tasks >> of JDK-8252536. >> >> Open Subtasks part of this fix are: >> 1. JDK-8252537 >> 2. JDK-8252539 >> 3. JDK-8252540 >> 4. JDK-8252541 >> >> Previous conversation

Re: RFR: 8252537: Updated @exception with @throws [v4]

2020-09-28 Thread Lance Andersen
On Sun, 27 Sep 2020 12:46:21 GMT, Vipin Sharma wrote: >> Updated @exception with @throws for core-libs, it fixes all open sub-tasks >> of JDK-8252536. >> >> Open Subtasks part of this fix are: >> 1. JDK-8252537 >> 2. JDK-8252539 >> 3. JDK-8252540 >> 4. JDK-8252541 >> >> Previous conversation

Re: RFR: 8252537: Updated @exception with @throws [v4]

2020-09-27 Thread Vipin Sharma
> Updated @exception with @throws for core-libs, it fixes all open sub-tasks of > JDK-8252536. > > Open Subtasks part of this fix are: > 1. JDK-8252537 > 2. JDK-8252539 > 3. JDK-8252540 > 4. JDK-8252541 > > Previous conversation on this: >

Re: RFR: 8252537: Updated @exception with @throws [v3]

2020-09-24 Thread Lance Andersen
On Thu, 24 Sep 2020 18:20:15 GMT, Vipin Sharma wrote: > > Overall the changes look OK. in the java.sql set of classes, please updated > > the modified statements to also use {@code} > > Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a > separate bug JDK-8253612 to fix

Re: RFR: 8252537: Updated @exception with @throws [v3]

2020-09-24 Thread Vipin Sharma
On Thu, 24 Sep 2020 17:30:52 GMT, Lance Andersen wrote: > Overall the changes look OK. in the java.sql set of classes, please updated > the modified statements to also use {@code} Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a separate bug JDK-8253612 to fix this

Re: RFR: 8252537: Updated @exception with @throws [v3]

2020-09-24 Thread Lance Andersen
On Sat, 19 Sep 2020 20:24:14 GMT, Vipin Sharma wrote: >> Updated @exception with @throws for core-libs, it fixes all open sub-tasks >> of JDK-8252536. >> >> Open Subtasks part of this fix are: >> 1. JDK-8252537 >> 2. JDK-8252539 >> 3. JDK-8252540 >> 4. JDK-8252541 >> >> Previous conversation

Re: RFR: 8252537: Updated @exception with @throws [v3]

2020-09-20 Thread Serguei Spitsyn
On Sat, 19 Sep 2020 20:24:14 GMT, Vipin Sharma wrote: >> Updated @exception with @throws for core-libs, it fixes all open sub-tasks >> of JDK-8252536. >> >> Open Subtasks part of this fix are: >> 1. JDK-8252537 >> 2. JDK-8252539 >> 3. JDK-8252540 >> 4. JDK-8252541 >> >> Previous conversation

Re: RFR: 8252537: Updated @exception with @throws [v3]

2020-09-19 Thread Vipin Sharma
> Updated @exception with @throws for core-libs, it fixes all open sub-tasks of > JDK-8252536. > > Open Subtasks part of this fix are: > 1. JDK-8252537 > 2. JDK-8252539 > 3. JDK-8252540 > 4. JDK-8252541 > > Previous conversation on this: >

Re: RFR: 8252537: Updated @exception with @throws [v2]

2020-09-19 Thread Vipin Sharma
On Tue, 15 Sep 2020 19:19:07 GMT, Roger Riggs wrote: >> @RogerRiggs I understand your point and will update PR with correct >> indentation. >> But I think adding 3 spaces after throws may not be right for all cases. >> For example when >> 1. Another tag in same method is using only 1 space. >>

Re: RFR: 8252537: Updated @exception with @throws [v2]

2020-09-19 Thread Vipin Sharma
> Updated @exception with @throws for core-libs, it fixes all open sub-tasks of > JDK-8252536. > > Open Subtasks part of this fix are: > 1. JDK-8252537 > 2. JDK-8252539 > 3. JDK-8252540 > 4. JDK-8252541 > > Previous conversation on this: >

Re: RFR: 8252537: Updated @exception with @throws

2020-09-15 Thread Roger Riggs
On Tue, 15 Sep 2020 19:13:55 GMT, Vipin Sharma wrote: >> I've only looked at the management files. They look good in general. >> >> src/java.management/share/classes/java/lang/management/ClassLoadingMXBean.java >> >> 108 * @throws java.lang.SecurityException if a security manager >> 109

Re: RFR: 8252537: Updated @exception with @throws

2020-09-15 Thread Vipin Sharma
On Tue, 15 Sep 2020 18:14:58 GMT, Serguei Spitsyn wrote: >> Updated @exception with @throws for core-libs, it fixes all open sub-tasks >> of JDK-8252536. >> >> Open Subtasks part of this fix are: >> 1. JDK-8252537 >> 2. JDK-8252539 >> 3. JDK-8252540 >> 4. JDK-8252541 >> >> Previous

Re: RFR: 8252537: Updated @exception with @throws

2020-09-15 Thread Serguei Spitsyn
On Wed, 9 Sep 2020 19:29:30 GMT, Vipin Sharma wrote: > Updated @exception with @throws for core-libs, it fixes all open sub-tasks of > JDK-8252536. > > Open Subtasks part of this fix are: > 1. JDK-8252537 > 2. JDK-8252539 > 3. JDK-8252540 > 4. JDK-8252541 > > Previous conversation on this: >

Re: RFR: 8252537: Updated @exception with @throws

2020-09-14 Thread Roger Riggs
On Wed, 9 Sep 2020 19:29:30 GMT, Vipin Sharma wrote: > Updated @exception with @throws for core-libs, it fixes all open sub-tasks of > JDK-8252536. > > Open Subtasks part of this fix are: > 1. JDK-8252537 > 2. JDK-8252539 > 3. JDK-8252540 > 4. JDK-8252541 > > Previous conversation on this: >