Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v5]

2021-02-24 Thread Severin Gehwolf
On Wed, 24 Feb 2021 17:37:13 GMT, Severin Gehwolf wrote: >> Marked as reviewed by andrew (Reviewer). > > @gnu-andrew Thanks for the review! I'll retest and then integrate. Tests look good on my end. Also this check passed all Linux tests (it's a no-op everywhere else):

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v5]

2021-02-24 Thread Severin Gehwolf
On Wed, 24 Feb 2021 16:24:32 GMT, Andrew John Hughes wrote: >> Severin Gehwolf has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add comment to parsing logic of /proc/self/cgroup > > Marked as reviewed by andrew (Reviewer). @gnu-andrew

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v5]

2021-02-24 Thread Andrew John Hughes
On Fri, 12 Feb 2021 12:49:01 GMT, Severin Gehwolf wrote: >> This is an enhancement which solves two issues: >> >> 1. Multiple reads of relevant cgroup interface files. Now interface files >> are only read once per file (just like Hotspot). >> 2. Proxies creation of the impl specific subsystem

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v5]

2021-02-12 Thread Severin Gehwolf
> This is an enhancement which solves two issues: > > 1. Multiple reads of relevant cgroup interface files. Now interface files are > only read once per file (just like Hotspot). > 2. Proxies creation of the impl specific subsystem via `determineType()` as > before, but now reads all relevant