Re: RFR: 8256480: Refactor ObjectInputStream field reader implementation [v2]

2020-11-20 Thread Brent Christian
On Thu, 19 Nov 2020 20:32:17 GMT, Roger Riggs wrote: >> ObjectInputStream has nearly identical but separate implementations to read >> values from the stream. >> Both implementations read primitive and object values from the stream and >> return an object holding the values. >> OIS.readFields()

Re: RFR: 8256480: Refactor ObjectInputStream field reader implementation [v2]

2020-11-19 Thread Roger Riggs
> ObjectInputStream has nearly identical but separate implementations to read > values from the stream. > Both implementations read primitive and object values from the stream and > return an object holding the values. > OIS.readFields() uses the internal class GetFieldImpl while > OIS.defaultRe

Re: RFR: 8256480: Refactor ObjectInputStream field reader implementation

2020-11-19 Thread Roger Riggs
Hi Brent, Thanks for the review On 11/18/20 7:24 PM, Brent Christian wrote: Hi, Roger. The change looks good.  I just noticed a couple small things: 2324 for (int i = 0; i < slots.length-1; i++) { 2325 new FieldValues(slots[i].desc, true); The slots[i].hasData che

Re: RFR: 8256480: Refactor ObjectInputStream field reader implementation

2020-11-18 Thread Brent Christian
Hi, Roger. The change looks good. I just noticed a couple small things: 2324 for (int i = 0; i < slots.length-1; i++) { 2325 new FieldValues(slots[i].desc, true); The slots[i].hasData check is no longer performed here. 2561 primValues = new byte[desc.ge