Re: RFR: 8264029: Replace uses of StringBuffer with StringBuilder in java.base

2021-03-24 Thread Aleksey Shipilev
On Tue, 23 Mar 2021 21:54:33 GMT, Pavel Rappo wrote: >> I'm not sure how String.repeat can be used here. Repeated String is not >> constant and different for each iteration. > > Long runs of whitespace, especially in blank strings, may have poor > readability. I was thinking that > > " ".repea

Re: RFR: 8264029: Replace uses of StringBuffer with StringBuilder in java.base

2021-03-23 Thread Pavel Rappo
On Tue, 23 Mar 2021 20:44:17 GMT, Andrey Turbanov wrote: >> src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java line 1954: >> >>> 1952: for (int i = 0; i < 4; ++i) { >>> 1953: if (i > 0) { >>> 1954: sb.append(" "); >> >> Cons

Re: RFR: 8264029: Replace uses of StringBuffer with StringBuilder in java.base

2021-03-23 Thread Andrey Turbanov
On Tue, 23 Mar 2021 12:38:06 GMT, Pavel Rappo wrote: >> Found by IntelliJ IDEA inspection `Java | Java language level migration aids >> | Java 5 | 'StringBuffer' may be 'StringBuilder'` >> As suggested in >> https://github.com/openjdk/jdk/pull/1507#issuecomment-757369003 I've created >> separa

Re: RFR: 8264029: Replace uses of StringBuffer with StringBuilder in java.base

2021-03-23 Thread Pavel Rappo
On Wed, 10 Mar 2021 19:47:00 GMT, Andrey Turbanov wrote: > Found by IntelliJ IDEA inspection `Java | Java language level migration aids > | Java 5 | 'StringBuffer' may be 'StringBuilder'` > As suggested in > https://github.com/openjdk/jdk/pull/1507#issuecomment-757369003 I've created > separa

Re: RFR: 8264029: Replace uses of StringBuffer with StringBuilder in java.base

2021-03-23 Thread Aleksey Shipilev
On Wed, 10 Mar 2021 19:47:00 GMT, Andrey Turbanov wrote: > Found by IntelliJ IDEA inspection `Java | Java language level migration aids > | Java 5 | 'StringBuffer' may be 'StringBuilder'` > As suggested in > https://github.com/openjdk/jdk/pull/1507#issuecomment-757369003 I've created > separa