Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-23 Thread wxiang
On Thu, 16 Sep 2021 01:29:41 GMT, wxiang wrote: >> wxiang has updated the pull request incrementally with one additional commit >> since the last revision: >> >> add isEmpty check > > I have changed > > ENABLE_JAR_INDEX = p != null ? p.equals("true") : false; > > to > > ENABLE_JAR_INDEX

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-23 Thread Alan Bateman
On Thu, 16 Sep 2021 01:29:41 GMT, wxiang wrote: >> wxiang has updated the pull request incrementally with one additional commit >> since the last revision: >> >> add isEmpty check > > I have changed > > ENABLE_JAR_INDEX = p != null ? p.equals("true") : false; > > to > > ENABLE_JAR_INDEX

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-16 Thread wxiang
On Thu, 16 Sep 2021 11:08:17 GMT, Alan Bateman wrote: >> wxiang has updated the pull request incrementally with one additional commit >> since the last revision: >> >> add isEmpty check > > src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 949: > >> 947:

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-16 Thread Alan Bateman
On Thu, 16 Sep 2021 01:29:12 GMT, wxiang wrote: >> There is a bug for URLClassPath.findResources with JarIndex. >> Currently, there was agreement on dropping the support from the >> URLClassLoader implementation but it was suggested that it should be >> disabled for a release or two before

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-16 Thread Lance Andersen
On Thu, 16 Sep 2021 01:29:12 GMT, wxiang wrote: >> There is a bug for URLClassPath.findResources with JarIndex. >> Currently, there was agreement on dropping the support from the >> URLClassLoader implementation but it was suggested that it should be >> disabled for a release or two before

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-16 Thread Lance Andersen
On Thu, 16 Sep 2021 09:33:44 GMT, wxiang wrote: >> Given that there is a precedence in this file: >> >> >> p = >> props.getProperty("jdk.net.URLClassPath.showIgnoredClassPathEntries"); >> DEBUG_CP_URL_CHECK = p != null ? p.equals("true") || p.isEmpty() : >> false; >> >> >>

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-16 Thread wxiang
On Thu, 16 Sep 2021 09:15:34 GMT, Daniel Fuchs wrote: >> I can appreciate that and that is a fair point. I guess where I was >> coming from was that the property is temporary and has to be explicitly >> specified so ignoring the value seemed worth raising/discussing. >> >> Assuming the

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-16 Thread Daniel Fuchs
On Wed, 15 Sep 2021 19:41:11 GMT, Lance Andersen wrote: >> I would dislike it if `-Djdk.net.URLClassPath.enableJarIndex=false` meant >> true... > > I can appreciate that and that is a fair point. I guess where I was coming > from was that the property is temporary and has to be explicitly

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-16 Thread Daniel Fuchs
On Thu, 16 Sep 2021 01:29:12 GMT, wxiang wrote: >> There is a bug for URLClassPath.findResources with JarIndex. >> Currently, there was agreement on dropping the support from the >> URLClassLoader implementation but it was suggested that it should be >> disabled for a release or two before

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-15 Thread wxiang
On Thu, 16 Sep 2021 01:29:12 GMT, wxiang wrote: >> There is a bug for URLClassPath.findResources with JarIndex. >> Currently, there was agreement on dropping the support from the >> URLClassLoader implementation but it was suggested that it should be >> disabled for a release or two before

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-15 Thread wxiang
> There is a bug for URLClassPath.findResources with JarIndex. > Currently, there was agreement on dropping the support from the > URLClassLoader implementation but it was suggested that it should be disabled > for a release or two before the code is removed. > A system property can be used to