Re: RFR: 8274276: Cache normalizedBase URL in URLClassPath.FileLoader [v2]

2021-09-27 Thread Daniel Fuchs
On Fri, 24 Sep 2021 11:50:21 GMT, Сергей Цыпанов wrote: >> Currently on each invocation of `URLClassPath.FileLoader.getResource()` >> `normalizedBase` URL is recalculated using same final `baseURL` from parent >> class. This can be avoided giving significant improvement in memory >>

Re: RFR: 8274276: Cache normalizedBase URL in URLClassPath.FileLoader [v2]

2021-09-24 Thread Сергей Цыпанов
On Fri, 24 Sep 2021 11:14:00 GMT, Daniel Fuchs wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274276: Make URLClassPath.Loader.getBaseURL() final > > This is calling an overidable method within a constructor,

Re: RFR: 8274276: Cache normalizedBase URL in URLClassPath.FileLoader [v2]

2021-09-24 Thread Сергей Цыпанов
> Currently on each invocation of `URLClassPath.FileLoader.getResource()` > `normalizedBase` URL is recalculated using same final `baseURL` from parent > class. This can be avoided giving significant improvement in memory > consumption. Consider the benchmark: > > @State(Scope.Benchmark) >