On Thu, 2 Dec 2021 12:13:03 GMT, Andrew Leonard wrote:
>> Addition of a configure option --with-cacerts-src='user cacerts folder' to
>> allow developers to specify their own cacerts PEM folder for generation of
>> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>>
>>
On Thu, 2 Dec 2021 19:12:37 GMT, Andrew Leonard wrote:
>> Oh, I didn't expand the diff far enough to actually see the context
>> correctly when I reviewed this as I would never have imagined the
>> conditional to be placed after the rule. While this will work as so far as
>> using the correct
On Thu, 2 Dec 2021 18:46:09 GMT, Erik Joelsson wrote:
>> this was my understanding:
>> https://www.gnu.org/software/make/manual/html_node/Variables-in-Recipes.html
>>
>> This occurs after make has finished reading all the makefiles and the target
>> is determined to be out of date; so, the
On Thu, 2 Dec 2021 18:03:50 GMT, Andrew Leonard wrote:
>> my assumption was the recipe gets resolved later
>
> this was my understanding:
> https://www.gnu.org/software/make/manual/html_node/Variables-in-Recipes.html
>
> This occurs after make has finished reading all the makefiles and the
On Thu, 2 Dec 2021 17:48:04 GMT, Andrew Leonard wrote:
>> you make a valid point, but i've tested this numerous times, but let me
>> check again
>
> my assumption was the recipe gets resolved later
this was my understanding:
On Thu, 2 Dec 2021 17:46:35 GMT, Andrew Leonard wrote:
>> I would have expected to see something like:
>>
>> ifneq ($(CACERTS_SRC), )
>> GENDATA_CACERTS_SRC := $(CACERTS_SRC)
>> else
>> GENDATA_CACERTS_SRC := $(TOPDIR)/make/data/cacerts/
>> endif
>>
>> at line 63.
>
> you make a valid
On Thu, 2 Dec 2021 17:35:36 GMT, Magnus Ihse Bursie wrote:
>> make/modules/java.base/Gendata.gmk line 76:
>>
>>> 74: ifneq ($(CACERTS_SRC), )
>>> 75: GENDATA_CACERTS_SRC := $(CACERTS_SRC)
>>> 76: endif
>>
>> Does this even work?! You are reassigning the variable after it has been
>> used.
On Thu, 2 Dec 2021 17:33:49 GMT, Magnus Ihse Bursie wrote:
>> Andrew Leonard has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>>
On Thu, 2 Dec 2021 12:13:03 GMT, Andrew Leonard wrote:
>> Addition of a configure option --with-cacerts-src='user cacerts folder' to
>> allow developers to specify their own cacerts PEM folder for generation of
>> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>>
>>
On Thu, 2 Dec 2021 14:29:00 GMT, Sean Mullan wrote:
> I don’t have any major concerns with this change, as long as the default
> cacerts are still the ones that are in the JDK. As an aside, using Mozilla's
> root certificates might be fine for TLS certificates, but if you need to
> support
On Thu, 2 Dec 2021 12:13:03 GMT, Andrew Leonard wrote:
>> Addition of a configure option --with-cacerts-src='user cacerts folder' to
>> allow developers to specify their own cacerts PEM folder for generation of
>> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>>
>>
On Thu, 2 Dec 2021 12:13:03 GMT, Andrew Leonard wrote:
>> Addition of a configure option --with-cacerts-src='user cacerts folder' to
>> allow developers to specify their own cacerts PEM folder for generation of
>> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>>
>>
> Addition of a configure option --with-cacerts-src='user cacerts folder' to
> allow developers to specify their own cacerts PEM folder for generation of
> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the
On Wed, 1 Dec 2021 18:47:41 GMT, Erik Joelsson wrote:
>> Andrew Leonard has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>>
14 matches
Mail list logo
