Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v6]

2022-02-28 Thread ExE Boss
On Fri, 25 Feb 2022 22:59:05 GMT, liach wrote: >> src/java.base/share/classes/java/util/Random.java line 298: >> >>> 296: */ >>> 297: public static Random from(RandomGenerator random) { >>> 298: return RandomWrapper.wrap(random); >> >> Might be good to check here or in the call

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v6]

2022-02-25 Thread Marcono1234
On Sun, 20 Feb 2022 03:15:22 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default me

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v6]

2022-02-25 Thread liach
On Tue, 22 Feb 2022 23:19:14 GMT, Marcono1234 wrote: >> Yasser Bazzi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove missed whitespace > > src/java.base/share/classes/java/util/Random.java line 298: > >> 296: */ >> 297:

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v6]

2022-02-22 Thread liach
On Sun, 20 Feb 2022 06:39:26 GMT, liach wrote: >> Yasser Bazzi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove missed whitespace > > src/java.base/share/classes/java/util/Random.java line 95: > >> 93: private static class Ran

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v6]

2022-02-22 Thread Jim Laskey
On Sun, 20 Feb 2022 03:15:22 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default me

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v6]

2022-02-19 Thread liach
On Sun, 20 Feb 2022 03:15:22 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default me

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v6]

2022-02-19 Thread Yasser Bazzi
> Hi, could i get a review on this implementation proposed by Stuart Marks, i > decided to use the > https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html > interface to create the default method `asRandom()` that wraps around the > newer algorithms