Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-26 Thread Jaikiran Pai
On Fri, 22 Apr 2022 08:04:09 GMT, Johnny Lim wrote: >> Hello @izeye, I've created a JBS issue for this change >> https://bugs.openjdk.java.net/browse/JDK-8285440. Please edit the title of >> this PR to "8285440: Typo in Collections.addAll method javadoc" so that it >> triggers the workflow of

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-26 Thread Roger Riggs
On Fri, 31 Dec 2021 18:58:43 GMT, Johnny Lim wrote: > This PR fixes a typo. Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6942

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Jaikiran Pai
On Fri, 31 Dec 2021 18:58:43 GMT, Johnny Lim wrote: > This PR fixes a typo. Thank you for contributing. The change looks fine to me. After someone with a Reviewer role approves this change, I can sponsor this for you. - Marked as reviewed by jpai (Committer). PR: https://git.open

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Johnny Lim
On Fri, 22 Apr 2022 07:35:52 GMT, Jaikiran Pai wrote: >> @robilad Hi. Thanks for the feedback! >> >> I submitted it again. I tried to fill it as possible as I can this time. >> Please let me know if there's anything missing. > > Hello @izeye, I've created a JBS issue for this change > https://

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Jaikiran Pai
On Fri, 25 Mar 2022 00:55:00 GMT, Johnny Lim wrote: >> Hi, >> >> please (re)submit a completed OCA at OCA.opensource.oracle.com. > > @robilad Hi. Thanks for the feedback! > > I submitted it again. I tried to fill it as possible as I can this time. > Please let me know if there's anything missi

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Johnny Lim
On Thu, 24 Mar 2022 20:28:59 GMT, Dalibor Topic wrote: >> This PR fixes a typo. > > Hi, > > please (re)submit a completed OCA at OCA.opensource.oracle.com. @robilad Hi. Thanks for the feedback! I submitted it again. I tried to fill it as possible as I can this time. Please let me know if ther

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Dalibor Topic
On Fri, 31 Dec 2021 18:58:43 GMT, Johnny Lim wrote: > This PR fixes a typo. Hi, please (re)submit a completed OCA at OCA.opensource.oracle.com. - PR: https://git.openjdk.java.net/jdk/pull/6942

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Julian Waters
On Fri, 31 Dec 2021 18:58:43 GMT, Johnny Lim wrote: > This PR fixes a typo. No need to worry, all you need to do is comment to reset the timer. There's nothing much else to do besides creating a JBS issue related to the PR (You do need one for the checks to pass, unfortunately I can't help you

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Johnny Lim
On Fri, 31 Dec 2021 18:58:43 GMT, Johnny Lim wrote: > This PR fixes a typo. @bridgekeeper I was waiting for "oca-verify", so I'm a bit confused. Please let me know if there's anything I need to do. - PR: https://git.openjdk.java.net/jdk/pull/6942