On Wed, 18 May 2022 15:05:26 GMT, Jorn Vernee wrote:
>> It's not quite that simple since a binding recipe for a single parameter can
>> have multiple VMStores for instance if a struct is decomposed into multiple
>> values.
>>
>> It can be done by pulling the binding loops up to the
On Wed, 18 May 2022 14:51:02 GMT, Jorn Vernee wrote:
>> I wasn't suggesting to add more bindings. I was more suggesting to filter
>> out the load/store from the set of bindings (since these are virtualized
>> anyways) that are passed to `doBindings`. Then, before executing a set of
>>
On Wed, 18 May 2022 14:21:55 GMT, Maurizio Cimadamore
wrote:
>> I'm not sure if there is anything actionable here?
>>
>> I've thought in the past that it might be nice to have
>> `GetArgument`/`SetArgument` and `GetReturnValue`/`SetReturnValue` binding
>> operators as well, to make the
On Wed, 18 May 2022 11:23:07 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java
>> line 336:
>>
>>> 334:
>>> 335: if (callingSequence.forUpcall()) {
>>> 336: // for upcalls, recipes have a result, which we handle
On Tue, 17 May 2022 08:41:59 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootstrapMethodError -> ExceptionInInitializerError
>
>
On Tue, 17 May 2022 11:18:20 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java
>> line 943:
>>
>>> 941: Z, B, S, C, I, J, F, D, L;
>>> 942:
>>> 943: static BasicType of(Class cls) {
>>
>> This seems a duplication of ASM
On Tue, 17 May 2022 06:00:37 GMT, Rémi Forax wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootstrapMethodError -> ExceptionInInitializerError
>
>
On Tue, 17 May 2022 10:08:00 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java
>> line 131:
>>
>>> 129: private int[] scopeSlots;
>>> 130: private int curScopeLocalIdx = -1;
>>> 131: private int RETURN_ALLOCATOR_IDX = -1;
>>
>>
On Tue, 17 May 2022 14:28:11 GMT, Rémi Forax wrote:
>> What about using MethodTypeDesc/ClassDesc as building block?
>
> yes, it should be less expensive, the ClassDesc still need to be constructed
> from Class to allow refactoring.
Can't wait for constant folding :)
I'll pull the
On Tue, 17 May 2022 11:57:01 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/SoftReferenceCache.java
>> line 42:
>>
>>> 40:
>>> 41: private class Node {
>>> 42: private SoftReference ref;
>>
>> this code looks like a double check locking so ref
On Tue, 17 May 2022 08:16:32 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java
>> line 98:
>>
>>> 96: private static final String CLASS_DATA_DESC =
>>> methodType(Object.class, MethodHandles.Lookup.class, String.class,
>>>
On Tue, 17 May 2022 05:51:58 GMT, Rémi Forax wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootstrapMethodError -> ExceptionInInitializerError
>
>
On Tue, 17 May 2022 06:13:04 GMT, Rémi Forax wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootstrapMethodError -> ExceptionInInitializerError
>
>
On Tue, 17 May 2022 08:32:54 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootstrapMethodError -> ExceptionInInitializerError
>
>
On Tue, 17 May 2022 05:54:39 GMT, Rémi Forax wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootstrapMethodError -> ExceptionInInitializerError
>
>
On Mon, 16 May 2022 17:40:41 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR brings over commits from the panama-foreign repo. These commits
>> mostly pertain to the switch to ASM and away from MethodHandle combinators
>> for the binding recipe specialization. But, there is one more commit which
On Mon, 16 May 2022 17:40:41 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR brings over commits from the panama-foreign repo. These commits
>> mostly pertain to the switch to ASM and away from MethodHandle combinators
>> for the binding recipe specialization. But, there is one more commit which
On Mon, 16 May 2022 17:40:41 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR brings over commits from the panama-foreign repo. These commits
>> mostly pertain to the switch to ASM and away from MethodHandle combinators
>> for the binding recipe specialization. But, there is one more commit which
On Mon, 16 May 2022 17:40:41 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR brings over commits from the panama-foreign repo. These commits
>> mostly pertain to the switch to ASM and away from MethodHandle combinators
>> for the binding recipe specialization. But, there is one more commit which
On Mon, 16 May 2022 17:40:41 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR brings over commits from the panama-foreign repo. These commits
>> mostly pertain to the switch to ASM and away from MethodHandle combinators
>> for the binding recipe specialization. But, there is one more commit which
On Thu, 12 May 2022 18:15:54 GMT, liach wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootstrapMethodError -> ExceptionInInitializerError
>
> test/micro/org/openjdk/bench/java/lang/foreign/LinkUpcall.java line
> Hi,
>
> This PR brings over commits from the panama-foreign repo. These commits
> mostly pertain to the switch to ASM and away from MethodHandle combinators
> for the binding recipe specialization. But, there is one more commit which
> adds freeing of downcall stubs, since those changes were
22 matches
Mail list logo