Thanks Martin!
webrev has been updated accordingly.
http://cr.openjdk.java.net/~sherman/8184947/webrev
I will try to see if I can do something for your canDecode(...) idea.
I'm still have a relative
big change in repo (mainly for the Strting(ByteBuffer ...) which might
move all those
utf8/as
Fix typo: singlton
Remove stray space:
+ba = Arrays.copyOfRange(ba, off, off + len);
Sorry, I haven't had the time I would like to review.
It would be good to make jdk10.
I keep wishing what we do for performance here wouldn't get so messy.
I keep thinking we should add some methods to the public Charset classes,
e.g. canDecode(byte[], int, int) with one general purpose implementat
On 12/12/2017 09:58 AM, Claes Redestad wrote:
StringCoding.java:
private static void throwMalformed(int nb) {
throw new IllegalArgumentException("malformed input length : " + nb);
}
nb is the number of bytes of the *first* offending chunk of bytes(?); is this
information
generally useful?
Hi Sherman,
On 2017-12-11 05:08, Xueming Shen wrote:
http://cr.openjdk.java.net/~sherman/8184947/webrev
thanks for incorporating my suggestion!
It looks pretty good to me. While many parts is just code that has been
moved, this is
still a pretty big change, so I hope we can get at least ano
On 12/10/17, 3:12 PM, Claes Redestad wrote:
Hi Sherman,
On 2017-12-09 00:09, Xueming Shen wrote:
Hi,
Please help review the changes for j.u.z.ZipCoder/JDK-8184947 (which
also includes
cleanup/improvement work in java.lang.StringCoding.java to speed up
general String
coding performance, espe
Hi Sherman,
On 2017-12-09 00:09, Xueming Shen wrote:
Hi,
Please help review the changes for j.u.z.ZipCoder/JDK-8184947 (which
also includes
cleanup/improvement work in java.lang.StringCoding.java to speed up
general String
coding performance, especially for UTF8).
issue: https://bugs.openjd
