Re: RFR: JDK-8219536: Add Option for user defined jlink options

2020-04-30 Thread Alexey Semenyuk
Looks good. - Alexey On 4/30/2020 11:23 AM, Andy Herrick wrote: Modified due to failure of new test on macosx.  The relative location of "release" file is different. Please review revised fix [7] /Andy [7] - http://cr.openjdk.java.net/~herrick/8219536/webrev.06/ On 4/29/2020 5:01 PM,

Re: RFR: JDK-8219536: Add Option for user defined jlink options

2020-04-30 Thread Alexander Matveev
Hi Andy, Looks good. Thanks, Alexander On 4/30/20 8:23 AM, Andy Herrick wrote: Modified due to failure of new test on macosx.  The relative location of "release" file is different. Please review revised fix [7] /Andy [7] - http://cr.openjdk.java.net/~herrick/8219536/webrev.06/ On

Re: RFR: JDK-8219536: Add Option for user defined jlink options

2020-04-30 Thread Andy Herrick
Modified due to failure of new test on macosx.  The relative location of "release" file is different. Please review revised fix [7] /Andy [7] - http://cr.openjdk.java.net/~herrick/8219536/webrev.06/ On 4/29/2020 5:01 PM, Alexey Semenyuk wrote: Looks good. - Alexey On 4/29/2020 2:36 PM,

Re: RFR: JDK-8219536: Add Option for user defined jlink options

2020-04-29 Thread Alexey Semenyuk
Looks good. - Alexey On 4/29/2020 2:36 PM, Andy Herrick wrote: I don't think I sent out webrev.5 [6] fixing Alexander's points below. Please Review: [6] http://cr.openjdk.java.net/~herrick/8219536/webrev.05/index.html /Andy On 4/23/2020 7:59 PM, Alexander Matveev wrote: Hi Andy,

Re: RFR: JDK-8219536: Add Option for user defined jlink options

2020-04-29 Thread Alexander Matveev
Hi Andy, Looks fine. Thanks, Alexander On 4/29/20 11:36 AM, Andy Herrick wrote: I don't think I sent out webrev.5 [6] fixing Alexander's points below. Please Review: [6] http://cr.openjdk.java.net/~herrick/8219536/webrev.05/index.html /Andy On 4/23/2020 7:59 PM, Alexander Matveev wrote:

Re: RFR: JDK-8219536: Add Option for user defined jlink options

2020-04-29 Thread Andy Herrick
I don't think I sent out webrev.5 [6] fixing Alexander's points below.  Please Review: [6] http://cr.openjdk.java.net/~herrick/8219536/webrev.05/index.html /Andy On 4/23/2020 7:59 PM, Alexander Matveev wrote: Hi Andy,

Re: RFR: JDK-8219536: Add Option for user defined jlink options

2020-04-23 Thread Alexander Matveev
Hi Andy, http://cr.openjdk.java.net/~herrick/8219536/webrev.04/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/Arguments.java.frames.html 1) Copyright year needs to be updated. Other files also needs copyright year to be updated. 2) Line 778: Not sure why it was moved

Re: RFR: JDK-8219536: Add Option for user defined jlink options

2020-04-23 Thread Alexey Semenyuk
Looks good. - Alexey On 4/23/2020 4:48 PM, Andy Herrick wrote: Please review updated webrev at [5] to address comments below from Alexey. [5] http://cr.openjdk.java.net/~herrick/8219536/webrev.04 /Andy On 4/23/2020 11:17 AM, Alexey Semenyuk wrote:

Re: RFR: JDK-8219536: Add Option for user defined jlink options

2020-04-23 Thread Andy Herrick
Please review updated webrev at [5] to address comments below from Alexey. [5] http://cr.openjdk.java.net/~herrick/8219536/webrev.04 /Andy On 4/23/2020 11:17 AM, Alexey Semenyuk wrote:

Re: RFR: JDK-8219536: Add Option for user defined jlink options

2020-04-23 Thread Alexey Semenyuk
http://cr.openjdk.java.net/~herrick/8219536/webrev.03/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java.sdiff.html:731 - 'launcherName' parameter of readRuntimeReleaseFile() function seems to be not used.