Re: RFR: JDK-8223333: Use try-with-resources where feasible

Hi Andy, Looks good. As well as other fixes you send yesterday for review. Thanks, Alexander On 6/6/2019 12:48 PM, Andy Herrick wrote: OK - revised MacCertificate as per below: webrev: http://cr.openjdk.java.net/~herrick/822/webrev.03 /Andy On 6/6/2019 12:47 PM, Alexey Semenyuk wrote: h

Re: RFR: JDK-8223333: Use try-with-resources where feasible

Looks good. - Alexey On 6/6/2019 3:48 PM, Andy Herrick wrote: OK - revised MacCertificate as per below: webrev: http://cr.openjdk.java.net/~herrick/822/webrev.03 /Andy On 6/6/2019 12:47 PM, Alexey Semenyuk wrote: http://cr.openjdk.java.net/~herrick/822/webrev.02/src/jdk.jpackage/maco

Re: RFR: JDK-8223333: Use try-with-resources where feasible

OK - revised MacCertificate as per below: webrev: http://cr.openjdk.java.net/~herrick/822/webrev.03 /Andy On 6/6/2019 12:47 PM, Alexey Semenyuk wrote: http://cr.openjdk.java.net/~herrick/822/webrev.02/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacCertificate.java.sdiff.html,

Re: RFR: JDK-8223333: Use try-with-resources where feasible

http://cr.openjdk.java.net/~herrick/822/webrev.02/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacCertificate.java.sdiff.html, lines 81-93 can be replaced with a single statement, something like: --- java.nio.file.Files.copy(   new ByteArrayInputStream(baos.toByteArray()),  

Re: RFR: JDK-8223333: Use try-with-resources where feasible

good catch - update 7 files to use Files.newBufferedWriter(). revised webrev: http://cr.openjdk.java.net/~herrick/822/webrev.02 /Andy On 6/6/2019 2:54 AM, Remi Forax wrote: Hi Andy, A code like this is not safe try (Writer w =

Re: RFR: JDK-8223333: Use try-with-resources where feasible

Hi Andy, A code like this is not safe try (Writer w = new BufferedWriter(new FileWriter( ... because new BufferedWriter may throw an OutOfMemoryError, in that case the file descriptor used by the FileWriter is not freed. There are two ways to fix that, either you need to expand the try-with-