Looks good.
On 9/24/2019 11:08 AM, Alexey Semenyuk wrote:
Looks good.
- Alexey
On 9/24/2019 1:24 PM, Andy Herrick wrote:
Revision 2 or the webrev ( [3] ) removes the comment about
`--linux-deb-copyright-file` option., replaces the literal strings
with the CLIOptions id's, and adds unit test
Looks good.
- Alexey
On 9/24/2019 1:24 PM, Andy Herrick wrote:
Revision 2 or the webrev ( [3] ) removes the comment about
`--linux-deb-copyright-file` option., replaces the literal strings
with the CLIOptions id's, and adds unit test to AddLauncherTest.java
[3] http://cr.openjdk.java.net/~h
Revision 2 or the webrev ( [3] ) removes the comment about
`--linux-deb-copyright-file` option., replaces the literal strings with
the CLIOptions id's, and adds unit test to AddLauncherTest.java
[3] http://cr.openjdk.java.net/~herrick/8230927/webrev.02/
/Andy
On 9/24/2019 9:19 AM, Alexey Sem
Andy,
Please remove javadoc update about `--linux-deb-copyright-file` option.
It will be dropped in https://bugs.openjdk.java.net/browse/JDK-8231277
patch.
Line 180:
---
if (additional.containsKey("java-optiions")) {
---
Looks like a typo. Should be "java-options", not "java-optiions", I guess
