On 5/27/2020 10:05 AM, Andy Herrick wrote:
looks good
curious why app.identifier was added to cfg file. I don't see it used
anywhere.
Right. That is why I removed it.
Thank you for the review!
- Alexey
/Andy
On 5/26/2020 3:26 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpack
looks good
curious why app.identifier was added to cfg file. I don't see it used
anywhere.
/Andy
On 5/26/2020 3:26 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Get rid of duplicated code parsing version strings. Move the code
parsing version strings to dedicated
Hi Alexey,
Looks good.
Thanks,
Alexander
On 5/26/20 12:26 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Get rid of duplicated code parsing version strings. Move the code
parsing version strings to dedicated classes with unit test coverage.
Also remove Mac specific i
