Re: RFR: regex changes -- sun.security.util.Debug issue

2016-05-10 Thread Mandy Chung
> On May 10, 2016, at 1:44 PM, Xueming Shen wrote: > > On 5/10/16 1:10 PM, Alan Bateman wrote: >> >> >> On 10/05/2016 19:57, Xueming Shen wrote: >>> webrev has been updated as suggested, now the lazily-init-class-holder is >>> used >>> to delay the Debug initialization. Tests all passed local

Re: RFR: regex changes -- sun.security.util.Debug issue

2016-05-10 Thread Xueming Shen
On 5/10/16 1:10 PM, Alan Bateman wrote: On 10/05/2016 19:57, Xueming Shen wrote: webrev has been updated as suggested, now the lazily-init-class-holder is used to delay the Debug initialization. Tests all passed locally. A jprt job is out to confirm. Here is the updated webrev http://cr.op

Re: RFR: regex changes -- sun.security.util.Debug issue

2016-05-10 Thread Alan Bateman
On 10/05/2016 19:57, Xueming Shen wrote: webrev has been updated as suggested, now the lazily-init-class-holder is used to delay the Debug initialization. Tests all passed locally. A jprt job is out to confirm. Here is the updated webrev http://cr.openjdk.java.net/~sherman/regexBackTrack.La

Re: RFR: regex changes -- sun.security.util.Debug issue

2016-05-10 Thread Roger Riggs
+1 On 5/10/2016 2:57 PM, Xueming Shen wrote: webrev has been updated as suggested, now the lazily-init-class-holder is used to delay the Debug initialization. Tests all passed locally. A jprt job is out to confirm. Here is the updated webrev http://cr.openjdk.java.net/~sherman/regexBackTrac

Re: RFR: regex changes -- sun.security.util.Debug issue

2016-05-10 Thread Xueming Shen
webrev has been updated as suggested, now the lazily-init-class-holder is used to delay the Debug initialization. Tests all passed locally. A jprt job is out to confirm. Here is the updated webrev http://cr.openjdk.java.net/~sherman/regexBackTrack.Lamnda.CanonEQ/webrev/ Thanks! Sherman On 05/

Re: RFR: regex changes -- sun.security.util.Debug issue

2016-05-10 Thread Xueming Shen
Sean, Given the "debug" is a private field and it is used only for debug != null in toString() -> seeAllp(), can the following change be a valid update? with the assumption that (1) the toString() is really not performance critical here, as we are changing from debug != null to

Re: RFR: regex changes -- sun.security.util.Debug issue

2016-05-10 Thread Sean Mullan
On 5/10/16 1:30 AM, Alan Bateman wrote: On 10/05/2016 06:36, Xueming Shen wrote: Hi, While testing for the attached regex changes, a fatal vm init error was triggered for test case with -Djava.security.debug=xyz turned on, as showed in following stacktrace. It appears sun.security.util.Debug

Re: RFR: regex changes -- sun.security.util.Debug issue

2016-05-10 Thread Alan Bateman
On 10/05/2016 06:36, Xueming Shen wrote: Hi, While testing for the attached regex changes, a fatal vm init error was triggered for test case with -Djava.security.debug=xyz turned on, as showed in following stacktrace. It appears sun.security.util.Debug is being initialized even before the l

Re: RFR: regex changes -- sun.security.util.Debug issue

2016-05-09 Thread Wang Weijun
Security-dev, If we can live with "engine=keystore" happily, why not just make the whole string lowercase and search for "permission=java.io.filepermission"? I don't think there are permission types or URL names that are only different in cases. Although file names are case-sensitive in Unix, I

Re: RFR: regex changes -- sun.security.util.Debug issue

2016-05-09 Thread Xueming Shen
Hi, While testing for the attached regex changes, a fatal vm init error was triggered for test case with -Djava.security.debug=xyz turned on, as showed in following stacktrace. It appears sun.security.util.Debug is being initialized even before the lambda is ready for use, and unfortunately