Hi,
Mike Duigou suggested some simplifications to the formatUnsigned
methods. Shows a slight speed-upon some micros as well:
http://cr.openjdk.java.net/~redestad/8050114/webrev.2/
/Claes
On 2014-07-13 00:26, Claes Redestad wrote:
Hi,
please review this patch to expose
Looks good. I will complete some additional testing and push this changeset for
you.
On Jul 18 2014, at 14:14 , Claes Redestad claes.redes...@oracle.com wrote:
Hi,
Mike Duigou suggested some simplifications to the formatUnsigned methods.
Shows a slight speed-upon some micros as well:
Hi Claes!
Wouldn't it be better to use do-while here:
339 while (charPos offset) {
340 buf[--charPos] = Integer.digits[val mask];
341 val = shift;
342 }
given the precondition
// assert len 0 (offset + len) = buf.length : illegal
You are correct. I will switch to a do-while.
Mike
On Jul 18 2014, at 15:20 , Ivan Gerasimov ivan.gerasi...@oracle.com wrote:
Hi Claes!
Wouldn't it be better to use do-while here:
339 while (charPos offset) {
340 buf[--charPos] = Integer.digits[val mask];
341
