RE: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

2017-02-14 Thread Frank Yuan
02/ > > > > Thanks > > Frank > > > >> -----Original Message- > >> From: Frank Yuan [mailto:frank.y...@oracle.com] > >> Subject: RE: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by > >> JDK-8087303 > >> > >&

Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

2017-02-14 Thread huizhe wang
stated in previous mail is made: http://cr.openjdk.java.net/~fyuan/8174025/webrev.02/ Thanks Frank -Original Message- From: Frank Yuan [mailto:frank.y...@oracle.com] Subject: RE: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303 -Original Message- From: h

RE: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

2017-02-14 Thread Frank Yuan
-Original Message- > From: Frank Yuan [mailto:frank.y...@oracle.com] > Subject: RE: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by > JDK-8087303 > > > > -Original Message- > > From: huizhe wang [mailto:huizhe.w...@oracle.com] > > Subject

RE: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

2017-02-14 Thread Frank Yuan
> -Original Message- > From: huizhe wang [mailto:huizhe.w...@oracle.com] > Subject: Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by > JDK-8087303 > > Looks good to me as well. > > For the CR and LF question, XML processors are required b

Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

2017-02-14 Thread huizhe wang
Best, Joe On 2/14/2017 6:58 AM, Frank Yuan wrote: -Original Message- From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] Subject: Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303 Hi Frank, On 14/02/17 13:43, Frank Yuan wrote: -Original Message-

RE: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

2017-02-14 Thread Frank Yuan
> -Original Message- > From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] > Subject: Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by > JDK-8087303 > > Hi Frank, > > On 14/02/17 13:43, Frank Yuan wrote: > > > >> -Origin

Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

2017-02-14 Thread Daniel Fuchs
Hi Frank, On 14/02/17 13:43, Frank Yuan wrote: -Original Message- From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] Subject: Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303 Hi Frank, Should you skip '\r' if it's not followed by '\n

RE: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

2017-02-14 Thread Frank Yuan
> -Original Message- > From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] > Subject: Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by > JDK-8087303 > > Hi Frank, > > Should you skip '\r' if it's not followed by '\n

Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

2017-02-14 Thread Daniel Fuchs
Hi Frank, Should you skip '\r' if it's not followed by '\n'? best regards, -- daniel On 14/02/17 10:33, Frank Yuan wrote: Hi Joe As you suggested, I made pretty-print a little better based on the fix. That is when adding indentation, just check the beginning character(s), in case of '\n' o

Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

2017-02-14 Thread Frank Yuan
Hi Joe As you suggested, I made pretty-print a little better based on the fix. That is when adding indentation, just check the beginning character(s), in case of '\n' or '\r' then, ignore it/them. Please check the new webrev: http://cr.openjdk.java.net/~fyuan/8174025/webrev.01/ Thanks Frank