Re: RFR 8065998: Avoid use of _ as a one-character identifier

2014-12-02 Thread Jan Lahoda
Thanks to all for the comments! Jan On 2.12.2014 11:15, Alan Bateman wrote: On 01/12/2014 13:37, Jan Lahoda wrote: : In TypeCheckMicroBenchmark then "ignore" is might be a misleading too given that the ArrayStoreException causes a CCE to be thrown. I've updated the patch to use "expected"

Re: RFR 8065998: Avoid use of _ as a one-character identifier

2014-12-02 Thread Alan Bateman
On 01/12/2014 13:37, Jan Lahoda wrote: : In TypeCheckMicroBenchmark then "ignore" is might be a misleading too given that the ArrayStoreException causes a CCE to be thrown. I've updated the patch to use "expected" where the exception appears to be expected and "unused" where exception appea

Re: RFR 8065998: Avoid use of _ as a one-character identifier

2014-12-01 Thread joe darcy
Hi Jan, The changes look good to me; thanks, -Joe On 12/1/2014 5:37 AM, Jan Lahoda wrote: On 1.12.2014 14:20, Alan Bateman wrote: On 01/12/2014 12:10, Jan Lahoda wrote: Hi, In a preparation for JDK-8061549, I'd like to rename all uses of '_' as a one-character identifier in the jaxp and jdk

Re: RFR 8065998: Avoid use of _ as a one-character identifier

2014-12-01 Thread Chris Hegarty
The changes looks fine to me Jan. -Chris. On 01/12/14 13:25, Jan Lahoda wrote: Thanks, makes sense. I've updated the patches so that in cases where (I think) the exception is expected, the name is "expected". I used "unused" in other cases where the fact that an exception was thrown is not igno

Re: RFR 8065998: Avoid use of _ as a one-character identifier

2014-12-01 Thread Jan Lahoda
On 1.12.2014 14:20, Alan Bateman wrote: On 01/12/2014 12:10, Jan Lahoda wrote: Hi, In a preparation for JDK-8061549, I'd like to rename all uses of '_' as a one-character identifier in the jaxp and jdk repositories. All the uses I was able to find are in tests, and the identifier is used as a n

Re: RFR 8065998: Avoid use of _ as a one-character identifier

2014-12-01 Thread Jan Lahoda
Thanks, makes sense. I've updated the patches so that in cases where (I think) the exception is expected, the name is "expected". I used "unused" in other cases where the fact that an exception was thrown is not ignored, but where the value of the exception parameter is not used. I've forgot (

Re: RFR 8065998: Avoid use of _ as a one-character identifier

2014-12-01 Thread Alan Bateman
On 01/12/2014 12:10, Jan Lahoda wrote: Hi, In a preparation for JDK-8061549, I'd like to rename all uses of '_' as a one-character identifier in the jaxp and jdk repositories. All the uses I was able to find are in tests, and the identifier is used as a name of a catch parameter. The proposed

Re: RFR 8065998: Avoid use of _ as a one-character identifier

2014-12-01 Thread Martijn Verburg
I know this is descending into bike shedding - but I like that split of definition, shamelessly stealing for my future projects, thanks! Cheers, Martijn On 1 December 2014 at 13:01, Andreas Lundblad wrote: > On Mon, Dec 01, 2014 at 01:10:29PM +0100, Jan Lahoda wrote: > > Hi, > > > > In a prepar

Re: RFR 8065998: Avoid use of _ as a one-character identifier

2014-12-01 Thread Andreas Lundblad
On Mon, Dec 01, 2014 at 01:10:29PM +0100, Jan Lahoda wrote: > Hi, > > In a preparation for JDK-8061549, I'd like to rename all uses of '_' > as a one-character identifier in the jaxp and jdk repositories. All > the uses I was able to find are in tests, and the identifier is used > as a name of a c

Re: RFR 8065998: Avoid use of _ as a one-character identifier

2014-12-01 Thread Martijn Verburg
If it helps "ignore" is a bit of a defacto std that I've seen many projects use, it conveys exactly the right intent :-). Cheers, Martijn On 1 December 2014 at 12:10, Jan Lahoda wrote: > Hi, > > In a preparation for JDK-8061549, I'd like to rename all uses of '_' as a > one-character identifier