Re: RFR 8155258: VarHandle implementation improvements

2016-05-04 Thread Vladimir Ivanov
PS: I wonder whether the MH cache in VarHandle (VarHandle.typesAndInvokers.methodHandle_table) should be idempotent or not. I am guessing you mean in terms of the MH ref identity? Yes, but I think it matters only if bytecode spinning happens (it does for LambdaForms). What matters for the

Re: RFR 8155258: VarHandle implementation improvements

2016-05-04 Thread Paul Sandoz
> On 4 May 2016, at 09:19, Vladimir Ivanov wrote: > > Looks good. > > I'm fine with pushing it directly into jdk9/dev, since the change just > relaxes the assert and the risk of a merge conflict is very small. > Thanks! > Best regards, > Vladimir Ivanov > > PS: I wonder whether the MH cac

Re: RFR 8155258: VarHandle implementation improvements

2016-05-04 Thread Vladimir Ivanov
Looks good. I'm fine with pushing it directly into jdk9/dev, since the change just relaxes the assert and the risk of a merge conflict is very small. Best regards, Vladimir Ivanov PS: I wonder whether the MH cache in VarHandle (VarHandle.typesAndInvokers.methodHandle_table) should be idempot

Re: RFR 8155258: VarHandle implementation improvements

2016-05-03 Thread Aleksey Shipilev
On 05/03/2016 09:35 PM, Paul Sandoz wrote: > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8155258-vhs-impl-improvements-jdk/webrev/ > Okay then, looks good. -Aleksey

Re: RFR 8155258: VarHandle implementation improvements

2016-05-03 Thread Paul Sandoz
> On 3 May 2016, at 06:11, Aleksey Shipilev wrote: > > On 05/03/2016 01:18 AM, Paul Sandoz wrote: >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8155258-vhs-impl-improvements-jdk/webrev/ >> >> >> >

Re: RFR 8155258: VarHandle implementation improvements

2016-05-03 Thread Aleksey Shipilev
On 05/03/2016 01:18 AM, Paul Sandoz wrote: > > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8155258-vhs-impl-improvements-jdk/webrev/ > > > > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8155258-vhs-imp