Re: RFR 8162108 Rename weakCompareAndSetVolatile to weakCompareAndSet

2016-08-24 Thread Paul Sandoz
> On 24 Aug 2016, at 15:48, Martin Buchholz wrote: > > Below it seems like weakCompareAndSetVolatile is susceptible to spurious > failure as much as other weak cas variants and so should have the same kind > of retry loop. > > { > boolean success = false; >

Re: RFR 8162108 Rename weakCompareAndSetVolatile to weakCompareAndSet

2016-08-24 Thread Martin Buchholz
Below it seems like weakCompareAndSetVolatile is susceptible to spurious failure as much as other weak cas variants and so should have the same kind of retry loop. { boolean success = false; for (int c = 0; c < WEAK_ATTEMPTS && !success; c++)

Re: RFR 8162108 Rename weakCompareAndSetVolatile to weakCompareAndSet

2016-08-24 Thread Paul Sandoz
> On 24 Aug 2016, at 14:17, Martin Buchholz wrote: > > Hi Paul, > > Thanks for doing this. > > Probably your IDE is fixing import statements. We'd prefer having that not > happen for j.u.c. but we can live with it. > Ah, i will update so as not to perturb that. > Of course, keeping all t

Re: RFR 8162108 Rename weakCompareAndSetVolatile to weakCompareAndSet

2016-08-24 Thread Martin Buchholz
On Wed, Aug 10, 2016 at 5:03 PM, Paul Sandoz wrote: > > This touches 166 classes that use or refer to the weak plain/volatile > methods. > Feel free to commit these. They will eventually break jsr166 CVS but we'll deal with it.

Re: RFR 8162108 Rename weakCompareAndSetVolatile to weakCompareAndSet

2016-08-24 Thread Martin Buchholz
Hi Paul, Thanks for doing this. Probably your IDE is fixing import statements. We'd prefer having that not happen for j.u.c. but we can live with it. Of course, keeping all the variants in sync is errorprone. Below is one case where what you're testing and what your assertions say are out of s

Re: RFR 8162108 Rename weakCompareAndSetVolatile to weakCompareAndSet

2016-08-24 Thread Paul Sandoz
Hi, Gentle reminder. Paul. > On 10 Aug 2016, at 17:03, Paul Sandoz wrote: > > Hi > > Please review: > > > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8162108-rename-weakCompareAndSetVolatile/webrev/ > >