Hi,
Updated to wrap long lines and remove unneeded @SuppressWarnings.
http://cr.openjdk.java.net/~rriggs/webrev-warn-serializable-8231314-2/
On 9/23/19 4:44 AM, Peter Levart wrote:
Once more, for the list (sorry)...
Hi,
On 9/21/19 12:31 PM, Chris Hegarty wrote:
Roger,
On 20 Sep 2019, at
Once more, for the list (sorry)...
Hi,
On 9/21/19 12:31 PM, Chris Hegarty wrote:
Roger,
On 20 Sep 2019, at 19:51, Roger Riggs wrote:
Please review code cleanup that will remove the need to suppress soon
to be introduced
warnings [1] about static typing of serialization related fields.
A f
Roger,
> On 20 Sep 2019, at 19:51, Roger Riggs wrote:
>
> Please review code cleanup that will remove the need to suppress soon to be
> introduced
> warnings [1] about static typing of serialization related fields.
> A few of the implementation Ser classes that serialize java.time types are
>
Hello,
Looks fine to me too. As Naoto observed, the patch is on top of a
changeset with annotations I haven't pushed yet; I think it would be
fine if this changeset were pushed first and I'll adjust mine accordingly.
Thanks,
-Joe
On 9/20/2019 2:03 PM, naoto.s...@oracle.com wrote:
Hi Roger,
Hi Roger,
Looks good to me.
There are some removed "@SuppressWarnings("serial")" which don't exist
in the current JDK14 code base, e.g., line 115 of java/time/Ser.java,
but I assumed they can be safely ignored.
Naoto
On 9/20/19 11:51 AM, Roger Riggs wrote:
Please review code cleanup that wi