Looks good to me as well!
I'll sponsor this and push it.
Best regards,
Volker
On Wed, Feb 5, 2020 at 6:47 AM Roger Riggs wrote:
>
> Looks good, Thanks
>
> On 2/4/20 8:06 PM, Verghese, Clive wrote:
> > Thank you for the quick feedback.
> >
> > I have updated the Webrev
> > http://cr.openjdk.jav
Looks good, Thanks
On 2/4/20 8:06 PM, Verghese, Clive wrote:
Thank you for the quick feedback.
I have updated the Webrev
http://cr.openjdk.java.net/~alvdavi/webrevs/8235699/webrev.8u.jdk.06/
Regards,
Clive Verghese
On 2/4/20, 4:42 PM, "core-libs-dev on behalf of Roger Riggs"
wrote:
Thank you for the quick feedback.
I have updated the Webrev
http://cr.openjdk.java.net/~alvdavi/webrevs/8235699/webrev.8u.jdk.06/
Regards,
Clive Verghese
On 2/4/20, 4:42 PM, "core-libs-dev on behalf of Roger Riggs"
wrote:
Hi Clive,
To clarify about the Oracle copyright, it
Hi Clive,
To clarify about the Oracle copyright, it should be included only if the
file was
derived from Oracle copyright source. The previous copyright is fine.
Sorry for any confusion.
Regards, Roger
On 2/4/20 5:20 PM, Roger Riggs wrote:
Hi Clive,
The update looks good to me.
Thanks, Ro
Hi Clive,
The update looks good to me.
Thanks, Roger
On 2/4/20 5:17 PM, Verghese, Clive wrote:
Hi Roger,
Thank you for the feedback. I have addressed your comments and updated the
Webrev.
http://cr.openjdk.java.net/~alvdavi/webrevs/8235699/
Regards,
Clive Verghese
On 2/4/20, 12:34 PM, "
Hi Roger,
Thank you for the feedback. I have addressed your comments and updated the
Webrev.
http://cr.openjdk.java.net/~alvdavi/webrevs/8235699/
Regards,
Clive Verghese
On 2/4/20, 12:34 PM, "core-libs-dev on behalf of Roger Riggs"
wrote:
Hi Clive,
A few comments:
Hi Clive,
A few comments:
The copyrights for the new files need to follow the template in
make/template/gpl-header.
In particular, it needs to include Oracle as a copyright holder.
bug235699.java:
The @summary should be more informative; "it works" tells nothing about
the case being tested.
Hi,
A Reminder for review.
Regards,
Clive Verghese
On 1/2/20, 1:18 PM, "Verghese, Clive" wrote:
Hi Alan,
Thanks for the feedback,
I have removed the @Author tag and updated the tests as per your
recommendation.
Updated Webrev
http://cr.openjdk.java.ne
Hi Alan,
Thanks for the feedback,
I have removed the @Author tag and updated the tests as per your
recommendation.
Updated Webrev
http://cr.openjdk.java.net/~phh/8235699/webrev.04/
Regards,
Clive Verghsese
Regards,
Clive Verghese
On 1/2/20, 11:19 AM, "Volker Simonis" wrote:
On 0
On 02.01.20 18:39, Alan Bateman wrote:
> On 02/01/2020 13:26, Volker Simonis wrote:
>> :
>> http://cr.openjdk.java.net/~simonis/webrevs/2020/8235699.02/
>>
>> Ready to push?
>>
> You shouldn't need to use core reflection here. Instead you can create
> the test so that it is compiled and runs as if
On 02/01/2020 13:26, Volker Simonis wrote:
:
http://cr.openjdk.java.net/~simonis/webrevs/2020/8235699.02/
Ready to push?
You shouldn't need to use core reflection here. Instead you can create
the test so that it is compiled and runs as if part of the java.text
package, e.g.
@build java.base
On 31.12.19 18:06, Alan Bateman wrote:
> On 31/12/2019 16:54, Verghese, Clive wrote:
>> Hi Volker,
>>
>> Thank you for reviewing the changes and approving.
>>
> Do you know if there is any test coverage for this method? The builder
> is package-private and I think your original mail said that it wa
On 31/12/2019 16:54, Verghese, Clive wrote:
Hi Volker,
Thank you for reviewing the changes and approving.
Do you know if there is any test coverage for this method? The builder
is package-private and I think your original mail said that it was
uncovered when invoking the toString from the deb
Thanks for the feedback, I will update the Copyright date.
Regards,
Clive Verghese
On 12/30/19, 6:06 PM, "felixxfyang(杨晓峰)" wrote:
Excuse me, Should be "Clive"
-Felix
在 2019/12/31 上午9:18，“felixxfyang(杨晓峰)” 写入:
Hi Volker，
Please update last modified date
Hi Volker,
Thank you for reviewing the changes and approving.
It would be great if you could sponsor the change as well.
Regards,
Clive Verghese
From: Volker Simonis
Date: Monday, December 30, 2019 at 3:13 PM
To: "Verghese, Clive"
Cc: Java Core Libs
Subject: Re: R
There is neither a test nor a noreg-* label.
I would add a regression test even if reflection is needed. Or you can make it
noreg-trivial.
Thanks,
Max
> On Dec 17, 2019, at 11:50 AM, Verghese, Clive wrote:
>
> Hi Volker,
>
> Thank you for the feedback.
>
> I have update the revision to ref
Excuse me, Should be "Clive"
-Felix
在 2019/12/31 上午9:18，“felixxfyang(杨晓峰)” 写入:
Hi Volker，
Please update last modified date "Copyright (c) 2010, 2014," to
"Copyright (c) 2010, 2019,"
Thanks,
Felix
在 2019/12/31 上午5:59，“core-libs-dev 代表 Hohensee,
Paul” 写入:
Hi Volker，
Please update last modified date "Copyright (c) 2010, 2014," to "Copyright
(c) 2010, 2019,"
Thanks,
Felix
在 2019/12/31 上午5:59，“core-libs-dev 代表 Hohensee,
Paul” 写入:
This revision looks fine to me.
Thanks,
Paul
On 12/16/19, 7:52 PM, "core-libs-dev on behalf
Hi Clive,
thanks for updating the patch.
Looks good now.
Do you need a sponsor for pushing?
Best regards,
Volker
Verghese, Clive schrieb am Di., 17. Dez. 2019, 04:50:
> Hi Volker,
>
> Thank you for the feedback.
>
> I have update the revision to reflect your comments.
> http://cr.openjdk.jav
This revision looks fine to me.
Thanks,
Paul
On 12/16/19, 7:52 PM, "core-libs-dev on behalf of Verghese, Clive"
wrote:
Hi Volker,
Thank you for the feedback.
I have update the revision to reflect your comments.
http://cr.openjdk.java.net/~phh/8235699/webrev.01/
Hi Volker,
Thank you for the feedback.
I have update the revision to reflect your comments.
http://cr.openjdk.java.net/~phh/8235699/webrev.01/
Regards,
Clive Verghese
On 12/13/19, 8:09 AM, "Volker Simonis" wrote:
Hi Clive,
nice catch :)
I think it would be better thou
Hi Clive,
nice catch :)
I think it would be better though to only iterate up to MAX_FIELD and
print "field[MAX_FIELD + i]", otherwise you may miss to print valid
fields. The reason is that with your current solution "isSet()" will
now be called not only for "stamp" fields, but also for "real" fie
Additional information regarding the field array.
It is meant to hold two arrays, the lower half holds the stamp. And the upper
half holds the fields.
The original implementation was intending to display the second half of the
array. Though the outer loop
iterated through the whole array. Theref
23 matches
Mail list logo
