Re: RFR 8246095: Tweaks to memory access API

2020-06-03 Thread Chris Hegarty
LGTM. The illustrative example in asUnsigned is nice ( I should have thought of similar, D’oh! ) -Chris. > On 3 Jun 2020, at 15:25, Maurizio Cimadamore > wrote: > > Please review this delta patch; I realized that the previously submitted > patch had few issues: > > * copyright header on Te

Re: RFR 8246095: Tweaks to memory access API

2020-06-03 Thread Maurizio Cimadamore
Please review this delta patch; I realized that the previously submitted patch had few issues: * copyright header on TestAdaptVarHandle benchmark was wrong * stream test for segment spliterator was not updated to include changes to copyFrom API * I've also incorporated a small javadoc tweak to

Re: RFR 8246095: Tweaks to memory access API

2020-05-29 Thread Maurizio Cimadamore
I added myself as reviewer on the CSR. Thanks The code looks good to me. Thanks for taking the time to include these API tweaks in JDK 15. Well, thank _you_ for contributing these great additions! Cheers Maurizio -Chris.

Re: RFR 8246095: Tweaks to memory access API

2020-05-29 Thread Paul Sandoz
+1 (reviewed on panama-dev) Paul. > On May 28, 2020, at 2:25 PM, Maurizio Cimadamore > wrote: > > Hi, > this followup change includes a number of tweaks that have been added to the > memory access API while we were in the process of integrating it. Most of > them have been contributed by Chr

Re: RFR 8246095: Tweaks to memory access API

2020-05-29 Thread Chris Hegarty
> On 28 May 2020, at 22:25, Maurizio Cimadamore > wrote: > > Hi, > this followup change includes a number of tweaks that have been added to the > memory access API while we were in the process of integrating it. Most of > them have been contributed by Chris (thanks!), and are all listed in