> On 4 Sep 2020, at 21:32, Vipin Sharma wrote:
>
>
> I have generated Javadoc for all updated packages and compared html files,
> before and after changes.
Since effects can be nonlocal (e.g. {@inheritDoc}), you should always compare
everything.
>> There are ~ 1.5K lines, 86 files changed in
Hi,
I have generated Javadoc for all updated packages and compared html files,
before and after changes.
All looks good, only generation time is different in html files.
Regards,
Vipin
> On Sep 5, 2020, at 12:47 AM, Vipin Sharma wrote:
>
> Hi Pavel,
>
>
>> On Sep 4, 2020, at 2:27 PM, Pavel
Hi Pavel,
> On Sep 4, 2020, at 2:27 PM, Pavel Rappo wrote:
>
> Oops, wrong issue number. Here's the correct one: JDK-8157682.
>
>> On 4 Sep 2020, at 09:52, Pavel Rappo wrote:
>>
>> It would be nice to compare documentation HTML files generated before and
>> after that patch: there's a possi
Hi Martin,
> On Sep 4, 2020, at 1:14 AM, Martin Buchholz wrote:
>
> Thanks for doing this!
>
> 15 years ago I considered taking on this task, eventually backing away
> because it was too much work (!). But I made sure most of the classes
> I maintained were using @throws.
>
> When considerin
Oops, wrong issue number. Here's the correct one: JDK-8157682.
> On 4 Sep 2020, at 09:52, Pavel Rappo wrote:
>
> It would be nice to compare documentation HTML files generated before and
> after that patch: there's a possibility of non-local consequences, see
> JDK-6509045.
>
> -Pavel
>
>> O
It would be nice to compare documentation HTML files generated before and after
that patch: there's a possibility of non-local consequences, see JDK-6509045.
-Pavel
> On 3 Sep 2020, at 20:33, Vipin Sharma wrote:
>
> Hi,
>
> Please review and sponsor the fix for replacing @exception with @thro
Thanks for doing this!
15 years ago I considered taking on this task, eventually backing away
because it was too much work (!). But I made sure most of the classes
I maintained were using @throws.
When considering this, I thought that tidying the whitespace after
conversion would be a big part o
Hi Vipin
I can sponsor once the review is complete as a vast majority are in java.sql
I will look at this tomorrow
> On Sep 3, 2020, at 3:33 PM, Vipin Sharma wrote:
>
> Hi,
>
> Please review and sponsor the fix for replacing @exception with @throws for
> core-libs.
>
> Issue: https://bugs.o
