Re: RFR JDK-7071819: To support Extended Grapheme Clusters in Regex

2016-02-03 Thread Xueming Shen
Hi Peter, Thanks for the review and suggestion. This appears to be a better approach. I was wondering if I should go this way to cache those lookup tables as well, but ... Webrev has been updated as suggested. Thanks! Sherman On 2/3/16 3:26 AM, Peter Levart wrote: Hi Again, I also have a

Re: RFR JDK-7071819: To support Extended Grapheme Clusters in Regex

2016-02-03 Thread Peter Levart
Hi Again, I also have a comment on the implementation of the hash table and it's GC-ness. You keep the string pool under a SoftReference because it is the biggest object so it makes most sense to clear it when heap becomes full. Other arrays are kept strongly reachable, but you re-generate the

Re: RFR JDK-7071819: To support Extended Grapheme Clusters in Regex

2016-02-03 Thread Peter Levart
Hi Sherman, I don't currently have any idea how to squeeze the hashtable any more further. It is already very compact in my opinion. But I noticed a data race that could result in navigating the half-initialized data structure. It is a classical unsafe publication bug. It has been present bef