Re: RFR JDK-8075526: Need a way to read and write time in UTC

2015-07-06 Thread Claes Redestad
On 2015-07-06 19:07, Xueming Shen wrote: On 07/06/2015 07:15 AM, Claes Redestad wrote: Hi, On 2015-07-01 19:05, Xueming Shen wrote: On 07/01/2015 05:02 AM, Claes Redestad wrote: Hi, On 2015-06-30 23:11, Xueming Shen wrote: Hi, Please help review and comment on this rfe. Issue: https://b

Re: RFR JDK-8075526: Need a way to read and write time in UTC

2015-07-06 Thread Xueming Shen
On 07/06/2015 07:15 AM, Claes Redestad wrote: Hi, On 2015-07-01 19:05, Xueming Shen wrote: On 07/01/2015 05:02 AM, Claes Redestad wrote: Hi, On 2015-06-30 23:11, Xueming Shen wrote: Hi, Please help review and comment on this rfe. Issue: https://bugs.openjdk.java.net/browse/JDK-8075526 webr

Re: RFR JDK-8075526: Need a way to read and write time in UTC

2015-07-06 Thread Claes Redestad
Hi, On 2015-07-01 19:05, Xueming Shen wrote: On 07/01/2015 05:02 AM, Claes Redestad wrote: Hi, On 2015-06-30 23:11, Xueming Shen wrote: Hi, Please help review and comment on this rfe. Issue: https://bugs.openjdk.java.net/browse/JDK-8075526 webrev: http://cr.openjdk.java.net/~sherman/8075526

Re: RFR JDK-8075526: Need a way to read and write time in UTC

2015-07-06 Thread Kumar Srinivasan
Hi Sherman, I am good with this. Thanks Kumar On 7/1/2015 3:19 PM, Xueming Shen wrote: Hi Kumar, thanks for the comments. Webrev has been updated according. On 7/1/15 2:09 PM, Kumar Srinivasan wrote: Hi Sherman, Thanks for solving this!, this has been a long standing issue for pack200.

Re: RFR JDK-8075526: Need a way to read and write time in UTC

2015-07-01 Thread Xueming Shen
Hi Kumar, thanks for the comments. Webrev has been updated according. On 7/1/15 2:09 PM, Kumar Srinivasan wrote: Hi Sherman, Thanks for solving this!, this has been a long standing issue for pack200. The changes looks generally good, I have also tested the initial prototype with pack200.

Re: RFR JDK-8075526: Need a way to read and write time in UTC

2015-07-01 Thread Kumar Srinivasan
Hi Sherman, Thanks for solving this!, this has been a long standing issue for pack200. The changes looks generally good, I have also tested the initial prototype with pack200. Some nitpicks: TestLocalTime.java: 0. line 51, s/supoprt/support/ 1. line 63, you have a "}" out of place 2. line 71, m

Re: RFR JDK-8075526: Need a way to read and write time in UTC

2015-07-01 Thread Xueming Shen
On 07/01/2015 05:02 AM, Claes Redestad wrote: Hi, On 2015-06-30 23:11, Xueming Shen wrote: Hi, Please help review and comment on this rfe. Issue: https://bugs.openjdk.java.net/browse/JDK-8075526 webrev: http://cr.openjdk.java.net/~sherman/8075526 I think this looks reasonable. I think we c

Re: RFR JDK-8075526: Need a way to read and write time in UTC

2015-07-01 Thread Claes Redestad
Hi, On 2015-06-30 23:11, Xueming Shen wrote: Hi, Please help review and comment on this rfe. Issue: https://bugs.openjdk.java.net/browse/JDK-8075526 webrev: http://cr.openjdk.java.net/~sherman/8075526 I think this looks reasonable. I think we could consolidate the LocalDateTime<->xdostime c