Re: RFR JDK 8 javac lint cleanup of java.lang.ref

2013-07-25 Thread Joseph Darcy
An update, I played around with the declarations a bit more, but wasn't about to find something workable so I pushed the already-reviewed version. If someone else wants to take a crack at improving the generics, I think that would be a fine refactoring. Thanks, -Joe On 7/25/2013 2:16 PM, Jo

Re: RFR JDK 8 javac lint cleanup of java.lang.ref

2013-07-25 Thread Joe Darcy
On 07/25/2013 01:58 PM, Alan Bateman wrote: On 25/07/2013 13:33, Joe Darcy wrote: Hello, Please review these changes to remove the javac lint warnings from the java.lang.ref package: 8021429 Fix lint warnings in java.lang.ref http://cr.openjdk.java.net/~darcy/8021429.0/ Care was tak

Re: RFR JDK 8 javac lint cleanup of java.lang.ref

2013-07-25 Thread Alan Bateman
On 25/07/2013 13:33, Joe Darcy wrote: Hello, Please review these changes to remove the javac lint warnings from the java.lang.ref package: 8021429 Fix lint warnings in java.lang.ref http://cr.openjdk.java.net/~darcy/8021429.0/ Care was taken to not change any signatures of public API

Re: RFR JDK 8 javac lint cleanup of java.lang.ref

2013-07-25 Thread Mike Duigou
These look fine to me. Mike On Jul 25 2013, at 13:33 , Joe Darcy wrote: > Hello, > > Please review these changes to remove the javac lint warnings from the > java.lang.ref package: > >8021429 Fix lint warnings in java.lang.ref >http://cr.openjdk.java.net/~darcy/8021429.0/ > > Care wa

Re: RFR JDK 8 javac lint cleanup of java.lang.ref

2013-07-25 Thread Lance Andersen - Oracle
Looks fine joe On Jul 25, 2013, at 4:33 PM, Joe Darcy wrote: > Hello, > > Please review these changes to remove the javac lint warnings from the > java.lang.ref package: > >8021429 Fix lint warnings in java.lang.ref >http://cr.openjdk.java.net/~darcy/8021429.0/ > > Care was taken to no