Re: Request for review: 7012206

2011-09-20 Thread David Holmes
There was an omission in the original webrev regarding the jtreg invocation changes for PrologSizeSanityCheck.java. The @run directive needs the name of the class to invoke + * @run main/othervm -XX:+UsePerfData PrologSizeSanityCheck Updated webrev at: http://cr.openjdk.java.net/~dholmes/70

Re: Request for review: 7012206

2011-09-20 Thread Kelly O'Hair
On Sep 19, 2011, at 10:05 PM, David Holmes wrote: > Thanks Alan. Other failures haven't shown up thus far so for now we'll just > address these ones (it improves the pass rate somewhat :) ). > > Could I get a second review from someone in serviceability? They look fine to me. -kto > > Thank

Re: Request for review: 7012206

2011-09-19 Thread David Holmes
Thanks Alan. Other failures haven't shown up thus far so for now we'll just address these ones (it improves the pass rate somewhat :) ). Could I get a second review from someone in serviceability? Thanks, David On 19/09/2011 6:57 PM, Alan Bateman wrote: David Holmes wrote: This a change to a

Re: Request for review: 7012206

2011-09-19 Thread Alan Bateman
David Holmes wrote: This a change to a bunch of serviceability tests (shell scripts that launch the various j* tools (jps, jstatd, jstack etc)) that I'd like to push through the TL JDK repo. The changes were done by Carlos Lucasius but I'm acting as his "sponsor" for getting these pushed. w