Re: Review Request for 8027481: jdeps to handle classes with the same package name ...

2013-10-30 Thread Mandy Chung
On 10/30/2013 7:38 AM, Alan Bateman wrote: On 30/10/2013 02:06, Mandy Chung wrote: I have added the test cases to verify dependency on javax.crypto and also a class in a SE package (javax.activity in the test case). The updated webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027481/

Re: Review Request for 8027481: jdeps to handle classes with the same package name ...

2013-10-30 Thread Mandy Chung
On 10/30/2013 3:54 AM, Daniel Fuchs wrote: On 10/30/13 3:06 AM, Mandy Chung wrote: I have added the test cases to verify dependency on javax.crypto and also a class in a SE package (javax.activity in the test case). The updated webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027481/web

Re: Review Request for 8027481: jdeps to handle classes with the same package name ...

2013-10-30 Thread Alan Bateman
On 30/10/2013 02:06, Mandy Chung wrote: I have added the test cases to verify dependency on javax.crypto and also a class in a SE package (javax.activity in the test case). The updated webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027481/webrev.01/ Mandy I've looked through the upd

Re: Review Request for 8027481: jdeps to handle classes with the same package name ...

2013-10-30 Thread Daniel Fuchs
On 10/30/13 3:06 AM, Mandy Chung wrote: I have added the test cases to verify dependency on javax.crypto and also a class in a SE package (javax.activity in the test case). The updated webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027481/webrev.01/ Looks good. What's the purpose of

Re: Review Request for 8027481: jdeps to handle classes with the same package name ...

2013-10-29 Thread Mandy Chung
I have added the test cases to verify dependency on javax.crypto and also a class in a SE package (javax.activity in the test case). The updated webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027481/webrev.01/ Mandy On 10/29/2013 2:37 PM, Mandy Chung wrote: On 10/29/13 2:19 PM, Dan

Re: Review Request for 8027481: jdeps to handle classes with the same package name ...

2013-10-29 Thread Mandy Chung
On 10/29/13 2:19 PM, Daniel Fuchs wrote: Hi Mandy, The changes look good to me - though I am a novice in this area: so I could have missed a few things. As a general comment I would say that this code could benefit from some more commenting - if you don't know what it's supposed to do then it i

Re: Review Request for 8027481: jdeps to handle classes with the same package name ...

2013-10-29 Thread Daniel Fuchs
Hi Mandy, The changes look good to me - though I am a novice in this area: so I could have missed a few things. As a general comment I would say that this code could benefit from some more commenting - if you don't know what it's supposed to do then it is a bit difficult to reverse-engineer :-)