Re: Review Request for JDK-8012937: Correct errors in javadoc comments

2013-04-24 Thread Joe Darcy
Please remove lines 157-159; otherwise, looks fine. Thanks, -Joe On 04/24/2013 09:35 AM, Eric McCorkle wrote: Any further comments, or is this one good to go? On 04/23/13 19:54, Joseph Darcy wrote: Acknowledged; thanks for checking, -Joe On 4/23/2013 7:46 AM, Eric McCorkle wrote: I believ

Re: Review Request for JDK-8012937: Correct errors in javadoc comments

2013-04-24 Thread Eric McCorkle
Any further comments, or is this one good to go? On 04/23/13 19:54, Joseph Darcy wrote: > Acknowledged; thanks for checking, > > -Joe > > On 4/23/2013 7:46 AM, Eric McCorkle wrote: >> I believe so. Alex Buckley recommended the exact wording. >> >> On 04/22/13 22:09, Joseph Darcy wrote: >>> Hell

Re: Review Request for JDK-8012937: Correct errors in javadoc comments

2013-04-23 Thread Joseph Darcy
Acknowledged; thanks for checking, -Joe On 4/23/2013 7:46 AM, Eric McCorkle wrote: I believe so. Alex Buckley recommended the exact wording. On 04/22/13 22:09, Joseph Darcy wrote: Hello, 240 * Returns the number of formal parameters (whether explicitly 241 * declared or implic

Re: Review Request for JDK-8012937: Correct errors in javadoc comments

2013-04-23 Thread Eric McCorkle
I believe so. Alex Buckley recommended the exact wording. On 04/22/13 22:09, Joseph Darcy wrote: > Hello, > > 240 * Returns the number of formal parameters (whether explicitly > 241 * declared or implicitly declared or neither) for the executable > > Are there parameters that are ne

Re: Review Request for JDK-8012937: Correct errors in javadoc comments

2013-04-22 Thread Joseph Darcy
Hello, 240 * Returns the number of formal parameters (whether explicitly 241 * declared or implicitly declared or neither) for the executable Are there parameters that are neither explicitly nor implicitly declared? I still think the follow comment is better deleted given the source

Re: Review Request for JDK-8012937: Correct errors in javadoc comments

2013-04-22 Thread Eric McCorkle
I have posted a newer version with some more edits. Please review and suggest any further changes. http://cr.openjdk.java.net/~emc/8012937/webrev.01/ On 04/22/13 12:10, Eric McCorkle wrote: > Hello, > > Please review this simple change, which corrects some errors in the > javadoc comments for m

Re: Review Request for JDK-8012937: Correct errors in javadoc comments

2013-04-22 Thread Joe Darcy
On 04/22/2013 09:10 AM, Eric McCorkle wrote: Hello, Please review this simple change, which corrects some errors in the javadoc comments for method parameter reflection. Note that this changeset does not include any code changes. The webrev is here: http://cr.openjdk.java.net/~emc/8012937/webr