Re: Review request for 6795561

2009-04-07 Thread Alan Bateman
ir...@alum.mit.edu wrote: : Given the unfortunate bug history of this method, I think that your approach is the way to go. I also agree with your evaluation to let the change bake in jdk7 then backport to an appropriate 6uX release. I approve. Given that your update will address the problem

RE: Review request for 6795561

2009-04-06 Thread irisg
Hi, Alan. Sorry it took me so long to get to this. I needed to carve out some time so that I could think about your changes and review a few things on bugs.sun.com. > From: Alan Bateman > Sent: Tuesday, March 24, 2009 1:48 AM > To: core-libs-dev > Subject: Review request for 6795561 > > 679556

Re: Review request for 6795561

2009-03-31 Thread Xueming Shen
looks good; approved. Alan Bateman wrote: 6795561: (bf) CharBuffer.subSequence() uses wrong capacity value for new buffer Iris, you might want to review this one. CharBuffer#subSequence(start,end) is specified to return a char buffer that has a position of position() + start, a limit of posi