Re: java.util patch for Warning Cleanup Day

2011-12-08 Thread Rémi Forax
On 12/06/2011 10:29 PM, Mike Duigou wrote: I have reviewed this patch and also run it against the java/util jtreg test. It looks good to me. Some comments: Currency.java: - The current mercurial source has one of your changes but the remaining two changes, diamond and @SW are still valid. Re

Re: java.util patch for Warning Cleanup Day

2011-12-06 Thread Naoto Sato
On 12/6/11 1:29 PM, Mike Duigou wrote: I have reviewed this patch and also run it against the java/util jtreg test. It looks good to me. Some comments: Currency.java: - The current mercurial source has one of your changes but the remaining two changes, diamond and @SW are still valid. For t

Re: java.util patch for Warning Cleanup Day

2011-12-06 Thread Mike Duigou
I have reviewed this patch and also run it against the java/util jtreg test. It looks good to me. Some comments: Currency.java: - The current mercurial source has one of your changes but the remaining two changes, diamond and @SW are still valid. ResourceBundle: - This file also has changes in