Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2013-01-10 Thread Lance Andersen - Oracle
Deven, This was pushed a while ago you should have seen the putback on the alias See http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a8978a5bb6e Best Lance On Jan 10, 2013, at 12:49 AM, Deven You wrote: Hi Lance, Is there any update for this issue. If you have anything I can do, please let

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2013-01-10 Thread Lance Andersen - Oracle
The JCK and RowSet TCK will have base tests to validate. I have a separate set of unit tests for JDBC which includes more detailed tests than what you had suggested as well as end to end tests. Best Lance On Jan 10, 2013, at 8:24 AM, Deven You wrote: Hi Lance, I am glad to see the patch

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2013-01-09 Thread Deven You
Hi Lance, Is there any update for this issue. If you have anything I can do, please let me know. Thanks a lot! On 11/24/2012 12:45 AM, Lance Andersen - Oracle wrote: It is on my list. to update the javadocs I need a ccc which I have not done yet and is needed as part of this change On Nov

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-11-23 Thread Deven You
Hi Lance, Is there any plan for this issue, if any could you update to me? Thanks a lot! On 10/29/2012 06:39 PM, Lance Andersen - Oracle wrote: Hi Deven, I will address the needed updates a bit later. Thank you for your input Best Lance On Oct 29, 2012, at 3:51 AM, Deven You wrote: Hi

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-11-23 Thread Lance Andersen - Oracle
It is on my list. to update the javadocs I need a ccc which I have not done yet and is needed as part of this change On Nov 23, 2012, at 3:07 AM, Deven You wrote: Hi Lance, Is there any plan for this issue, if any could you update to me? Thanks a lot! On 10/29/2012 06:39 PM, Lance

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-10-29 Thread Deven You
Hi Alan, The Java Spec does not mention the thread safe for JDBC API. But I see the other code in SerialBlob/SerialClob have not consider it. I think use buff == null to replace isFree is a good idea because it also avoid the problem for the condition buf == null isFree == false so we

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-10-29 Thread Lance Andersen - Oracle
Hi Deven, I will address the needed updates a bit later. Thank you for your input Best Lance On Oct 29, 2012, at 3:51 AM, Deven You wrote: Hi Alan, The Java Spec does not mention the thread safe for JDBC API. But I see the other code in SerialBlob/SerialClob have not consider it. I

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-09-21 Thread Alan Bateman
On 21/09/2012 04:21, Deven You wrote: Hi Lance, I am very busy with other work so I can't work with the SerialBlob/SerialClob item for long time. I am very happy to refine the current test case and create new tests for SerialClob. I have create a new webre[1] for this task, please review

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-09-20 Thread Deven You
Hi Lance, I am very busy with other work so I can't work with the SerialBlob/SerialClob item for long time. I am very happy to refine the current test case and create new tests for SerialClob. I have create a new webre[1] for this task, please review it. [1]

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-07-05 Thread Deven You
Hi Lance, Did you review the patch and compare it to yours. I just have some more words for the patch. 1. I think the current spec for free() is not clear, how about add below comments: After free has been called, any attempt to invoke a method other than free will result in a

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-07-05 Thread Lance Andersen - Oracle
Hi Deven, We had a holiday here on Weds, so I am still catching up. First, thank you for taking the time to propose a patch. Here are a few comments based on the changes I have made in my workspace and comparing to your proposed changes - The same issue applies to SerialClob - instead of

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-07-02 Thread Deven You
Hi All, Could anyone notice this problem? Thanks a lot! On 06/25/2012 04:18 PM, Deven You wrote: Hi All, First of all, if the jdbc problem has a better mailing list to post please tell me. I find that javax.sql.rowset.serial.SerialBlob is not fully implemented in OpenJDK 8. Methods

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-07-02 Thread Lance Andersen - Oracle
Hi Deven, Thanks for the email and the proposed patch. I will look at this later today or tomorrow. I actually have made these changes in my workspace for JDK 8 but will compare your changes to mine. Best Lance On Jul 2, 2012, at 5:04 AM, Deven You wrote: Hi All, Could anyone notice this