Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-23 Thread Chris Hegarty
On 11/23/11 01:29 PM, Neil Richards wrote: On Tue, 2011-11-22 at 19:09 +, Chris Hegarty wrote: On 11/22/11 06:56 PM, Alan Bateman wrote: On 22/11/2011 17:22, Neil Richards wrote: : Can you tell me, when jtreg decides to fire an interrupt at a test, has it already concluded that the

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-23 Thread Joe Darcy
Hello, On 11/22/2011 9:57 PM, David Holmes wrote: Hi Neil, On 22/11/2011 9:51 PM, Neil Richards wrote: I've created a webrev [1] to address the problem reported in bug 7094995, where the ClearStaleZipFileInputStreams testcase leaves a lingering GC inducing thread running after the test ends

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-23 Thread David Holmes
Hi Joe, On 24/11/2011 2:33 AM, Joe Darcy wrote: On 11/22/2011 9:57 PM, David Holmes wrote: On 22/11/2011 9:51 PM, Neil Richards wrote: I've also converted the testcase's use of ZipFile, ZipOutputStream FileOutputStream to use ARM (for greater clarity). I think proper use of ARM requires

Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-22 Thread Neil Richards
Hi all, I've created a webrev [1] to address the problem reported in bug 7094995, where the ClearStaleZipFileInputStreams testcase leaves a lingering GC inducing thread running after the test ends (when run in agentvm mode), as spotted by Alan and mentioned in another conversation [2]. It

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-22 Thread Neil Richards
On Tue, 2011-11-22 at 15:49 +, Alan Bateman wrote: On 22/11/2011 11:51, Neil Richards wrote: Hi all, I've created a webrev [1] to address the problem reported in bug 7094995, where the ClearStaleZipFileInputStreams testcase leaves a lingering GC inducing thread running after the

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-22 Thread Chris Hegarty
This change does look good. Not directly related to your changes Neil, and I know we swallow InterruptedException in many tests, but does it make sense to set keepRunning = false if the GcInducingThread is interrupted? jtreg will use Thread.interrupt when trying to cleanup after the test

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-22 Thread Neil Richards
On Tue, 2011-11-22 at 16:56 +, Chris Hegarty wrote: This change does look good. Not directly related to your changes Neil, and I know we swallow InterruptedException in many tests, but does it make sense to set keepRunning = false if the GcInducingThread is interrupted? jtreg will

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-22 Thread Neil Richards
On Tue, 2011-11-22 at 17:22 +, Neil Richards wrote: On Tue, 2011-11-22 at 16:56 +, Chris Hegarty wrote: This change does look good. Not directly related to your changes Neil, and I know we swallow InterruptedException in many tests, but does it make sense to set keepRunning =

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-22 Thread Alan Bateman
On 22/11/2011 17:22, Neil Richards wrote: : Can you tell me, when jtreg decides to fire an interrupt at a test, has it already concluded that the test has failed (or, at least, not passed) ? With othervm (the default) then each test is run in its own VM so the process termination will ensure

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-22 Thread Chris Hegarty
On 11/22/11 06:56 PM, Alan Bateman wrote: On 22/11/2011 17:22, Neil Richards wrote: : Can you tell me, when jtreg decides to fire an interrupt at a test, has it already concluded that the test has failed (or, at least, not passed) ? With othervm (the default) then each test is run in its own

Re: Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

2011-11-22 Thread David Holmes
Hi Neil, On 22/11/2011 9:51 PM, Neil Richards wrote: I've created a webrev [1] to address the problem reported in bug 7094995, where the ClearStaleZipFileInputStreams testcase leaves a lingering GC inducing thread running after the test ends (when run in agentvm mode), as spotted by Alan and