Re: Request for Review: Chain more Exceptions (RuntimeException)

2011-08-21 Thread Sebastian Sickelmann
Am 20.08.2011 00:04, schrieb Sebastian Sickelmann: Am 19.08.2011 23:21, schrieb Alan Bateman: Sebastian Sickelmann wrote: OK. We need to change the serialversion. But is this enough? May we break applications out there which serialized NoSuchMechanismExceptions or extended classes? I have comp

Re: Request for Review: Chain more Exceptions (RuntimeException)

2011-08-19 Thread Sebastian Sickelmann
Am 19.08.2011 23:21, schrieb Alan Bateman: Sebastian Sickelmann wrote: OK. We need to change the serialversion. But is this enough? May we break applications out there which serialized NoSuchMechanismExceptions or extended classes? I have compiled it with no explicit serialversionUID and start

Re: Request for Review: Chain more Exceptions (RuntimeException)

2011-08-19 Thread Alan Bateman
Sebastian Sickelmann wrote: OK. We need to change the serialversion. But is this enough? May we break applications out there which serialized NoSuchMechanismExceptions or extended classes? I have compiled it with no explicit serialversionUID and started ./serialver javax.xml.crypto.NoSuchMecha

Re: Request for Review: Chain more Exceptions (RuntimeException)

2011-08-19 Thread Sebastian Sickelmann
Am 18.08.2011 22:14, schrieb Alan Bateman: Sebastian Sickelmann wrote: Hi, i have created a fix for fixing Exception-Chains in case of an rethrown RuntimeException. I am not quite sure if this is inside the scope of what i discussed[0][1] with Joe. But it is fixed in the same manner as the

Re: Request for Review: Chain more Exceptions (RuntimeException)

2011-08-19 Thread Lance Andersen - Oracle
Should we start a page on OpenJDK as a coding practice FAQ for code and tests? On Aug 18, 2011, at 6:55 PM, joe.da...@oracle.com wrote: > > > On 8/18/2011 1:14 PM, Alan Bateman wrote: >> Sebastian Sickelmann wrote: >>> Hi, >>> >>> i have created a fix for fixing Exception-Chains in case of a

Re: Request for Review: Chain more Exceptions (RuntimeException)

2011-08-18 Thread Mike Duigou
I will echo Joe's comments about putting the "|" at the end of the line rather than at the beginning of the next line. Not a comment on your patch but some of the use of raw RuntimeException is rather weak. I saw a few cases where IllegalStateException or UnsupportedOperationException would be

Re: Request for Review: Chain more Exceptions (RuntimeException)

2011-08-18 Thread joe . darcy
On 8/18/2011 1:14 PM, Alan Bateman wrote: Sebastian Sickelmann wrote: Hi, i have created a fix for fixing Exception-Chains in case of an rethrown RuntimeException. I am not quite sure if this is inside the scope of what i discussed[0][1] with Joe. But it is fixed in the same manner as th

Re: Request for Review: Chain more Exceptions (RuntimeException)

2011-08-18 Thread Alan Bateman
Sebastian Sickelmann wrote: Hi, i have created a fix for fixing Exception-Chains in case of an rethrown RuntimeException. I am not quite sure if this is inside the scope of what i discussed[0][1] with Joe. But it is fixed in the same manner as the patches there. http://oss-patches.24.eu/op

Re: Request for Review: Chain more Exceptions (RuntimeException)

2011-08-18 Thread Dr Andrew John Hughes
On 07:01 Thu 18 Aug , Sebastian Sickelmann wrote: > Hi, > > i have created a fix for fixing Exception-Chains in case of an rethrown > RuntimeException. > > I am not quite sure if this is inside the scope of what i > discussed[0][1] with Joe. But it is > fixed in the same manner as the patch

Request for Review: Chain more Exceptions (RuntimeException)

2011-08-17 Thread Sebastian Sickelmann
Hi, i have created a fix for fixing Exception-Chains in case of an rethrown RuntimeException. I am not quite sure if this is inside the scope of what i discussed[0][1] with Joe. But it is fixed in the same manner as the patches there. http://oss-patches.24.eu/openjdk8/RuntimeException/REBAS