Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-29 Thread Andrew Haley
Dalibor Topic wrote: > Andrew Haley wrote: >> I think that jcheck is demanding that the merge comment must be "Merge", >> but "hg fetch" generates "Automated merge with ..." >> >> Surely this must happen to people inside Sun all the time. So how do >> y'all cope with it? > > in .hgrc I've got: >

Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-28 Thread Andrew John Hughes
2009/5/28 Andrew Haley : > Joseph D. Darcy wrote: >> Andrew Haley wrote: >>> Joseph D. Darcy wrote: >>> Alan Bateman wrote: > Andrew Haley wrote: > >> : >> OK, here it is.  I put the test in java/lang/Double/ToString.java >> rather than sun/misc/FloatingDecimal because

Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-28 Thread Dalibor Topic
Andrew Haley wrote: > I think that jcheck is demanding that the merge comment must be "Merge", > but "hg fetch" generates "Automated merge with ..." > > Surely this must happen to people inside Sun all the time. So how do > y'all cope with it? in .hgrc I've got: fetch = -m Merge cheers, dalibo

Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-28 Thread Andrew Haley
Joseph D. Darcy wrote: > Andrew Haley wrote: >> Joseph D. Darcy wrote: >> >>> Alan Bateman wrote: >>> Andrew Haley wrote: > : > OK, here it is. I put the test in java/lang/Double/ToString.java > rather than sun/misc/FloatingDecimal because the bug manifested >

Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-28 Thread Joseph D. Darcy
Andrew Haley wrote: Joseph D. Darcy wrote: Alan Bateman wrote: Andrew Haley wrote: : OK, here it is. I put the test in java/lang/Double/ToString.java rather than sun/misc/FloatingDecimal because the bug manifested itself in Double.toString although the fix was in FloatingDecima

Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-28 Thread Xueming Shen
Andrew Haley wrote: Alan Bateman wrote: Andrew Haley wrote: : To which openjdk7 repo do you want me to push this? My best guess is jdk7/jdk7-gate/jdk. jdk7/tl-gate/jdk is where libs changes should be pushed. OK. Just for my curiosity, what does "tl" stand for? I gues

Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-28 Thread Andrew Haley
Alan Bateman wrote: > Andrew Haley wrote: >> : >> To which openjdk7 repo do you want me to push this? >> My best guess is jdk7/jdk7-gate/jdk. >> > jdk7/tl-gate/jdk is where libs changes should be pushed. OK. Just for my curiosity, what does "tl" stand for? I guessed it was something to do wit

Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-28 Thread Alan Bateman
Andrew Haley wrote: : To which openjdk7 repo do you want me to push this? My best guess is jdk7/jdk7-gate/jdk. jdk7/tl-gate/jdk is where libs changes should be pushed. -Alan.

Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-28 Thread Andrew Haley
Joseph D. Darcy wrote: > Alan Bateman wrote: >> Andrew Haley wrote: >>> : >>> OK, here it is. I put the test in java/lang/Double/ToString.java >>> rather than sun/misc/FloatingDecimal because the bug manifested >>> itself in Double.toString although the fix was in >>> FloatingDecimal.dtoa. >>>

Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-28 Thread Andrew Haley
Joseph D. Darcy wrote: > Alan Bateman wrote: >> Andrew Haley wrote: >>> : >>> OK, here it is. I put the test in java/lang/Double/ToString.java >>> rather than sun/misc/FloatingDecimal because the bug manifested >>> itself in Double.toString although the fix was in >>> FloatingDecimal.dtoa. >>>

Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-25 Thread Joseph D. Darcy
Alan Bateman wrote: Andrew Haley wrote: : OK, here it is. I put the test in java/lang/Double/ToString.java rather than sun/misc/FloatingDecimal because the bug manifested itself in Double.toString although the fix was in FloatingDecimal.dtoa. I agree that test/java/lang/Double is the best pl

Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-22 Thread Alan Bateman
Andrew Haley wrote: : OK, here it is. I put the test in java/lang/Double/ToString.java rather than sun/misc/FloatingDecimal because the bug manifested itself in Double.toString although the fix was in FloatingDecimal.dtoa. I agree that test/java/lang/Double is the best place for this. All loo

Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-22 Thread Andrew Haley
Alan Bateman wrote: > Andrew Haley wrote: >> This bug has been in Java for a long time, and the fix has been in >> IcedTea >> for a year and a half. >> >> The bug is a trivial off-by-one error. >> >> OK for OpenJDK7 and OpenJDK6? >> >> Andrew. >> > It looks reasonable to me although Joe would be

Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-22 Thread Alan Bateman
Andrew Haley wrote: This bug has been in Java for a long time, and the fix has been in IcedTea for a year and a half. The bug is a trivial off-by-one error. OK for OpenJDK7 and OpenJDK6? Andrew. It looks reasonable to me although Joe would be the best person to review this. It would be goo

Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009-05-22 Thread Andrew Haley
This bug has been in Java for a long time, and the fix has been in IcedTea for a year and a half. The bug is a trivial off-by-one error. OK for OpenJDK7 and OpenJDK6? Andrew. --- oipenjdk/jdk/src/share/classes/sun/misc/FloatingDecimal.javaThu Sep 27 12:56:46 2007 -0700 +++ openjdk/jdk