Re: Request for review: 8000525: Java.net.httpcookie api does not support 2-digit year format

2012-12-12 Thread Rob McKenna
Hi Chris, I guess I figured if the parse failed the cal.set wouldn't happen. Still, no harm in moving the 1970 into the loop on the off chance something else goes wrong. I've updated the test too. Thanks for spotting that. -Rob On 10/12/12 16:59, Chris Hegarty wrote: Shouldn't

Re: Request for review: 8000525: Java.net.httpcookie api does not support 2-digit year format

2012-12-12 Thread Chris Hegarty
Thank you Rob, I'm ok with this change. -Chris. On 12/12/2012 15:44, Rob McKenna wrote: ...the url would be helpful: http://cr.openjdk.java.net/~robm/8000525/webrev.02/ -Rob On 12/12/12 15:43, Rob McKenna wrote: Hi Chris, I guess I figured if the parse failed the cal.set wouldn't happen.

Re: Request for review: 8000525: Java.net.httpcookie api does not support 2-digit year format

2012-12-10 Thread Chris Hegarty
Shouldn't 'cal.set(1970, 0, 1, 0, 0, 0)' be inside the for loop? The test can simply throw Exception, rather can catching. Otherwise, looks fine to me. -Crhis. On 06/12/2012 21:19, Rob McKenna wrote: Hi folks, According to HttpCookie.java: There are 3 http cookie specifications: Netscape

Request for review: 8000525: Java.net.httpcookie api does not support 2-digit year format

2012-12-06 Thread Rob McKenna
Hi folks, According to HttpCookie.java: There are 3 http cookie specifications: Netscape draft RFC 2109 -/http://www.ietf.org/rfc/rfc2109.txt/ RFC 2965 -/http://www.ietf.org/rfc/rfc2965.txt/ HttpCookie class can accept all these 3 forms of syntax. According to