Re: Request for review of JDK-8251548

2020-09-20 Thread David Holmes
On 18/09/2020 5:15 pm, Сергей Цыпанов wrote: Hi, Did you not follow these instructions to get your github account connected to your OCA record: Those are for "OpenJDK Author, Committer or Reviewer", but I'm only a contributor, i.e. I cannot file an issue or commit directly. My previous contr

Re: Request for review of JDK-8251548

2020-09-18 Thread Сергей Цыпанов
Hi, > Did you not follow these instructions to get your github account > connected to your OCA record: Those are for "OpenJDK Author, Committer or Reviewer", but I'm only a contributor, i.e. I cannot file an issue or commit directly. My previous contributions were shipped as *.patch files in ma

Re: Request for review of JDK-8251548

2020-09-17 Thread David Holmes
On 17/09/2020 7:24 pm, Сергей Цыпанов wrote: Hi David, thanks for pointing this out! I've created a PR there [1], but GitHub for some reason wants me to sign OCA, which I have already signed in 2017. I've redone the procedure and now I'm waiting for verification. Did you not follow these ins

Re: Request for review of JDK-8251548

2020-09-17 Thread Сергей Цыпанов
Hi David, thanks for pointing this out! I've created a PR there [1], but GitHub for some reason wants me to sign OCA, which I have already signed in 2017. I've redone the procedure and now I'm waiting for verification. Regards, Sergey 1. https://github.com/openjdk/jdk/pull/218 17.09.2020, 09:

Re: Request for review of JDK-8251548

2020-09-17 Thread David Holmes
Hi Sergey, Since OpenJDK has moved to git/github, this needs to reformulated as a Pull Request (PR). Cheers, David On 17/09/2020 5:19 pm, Сергей Цыпанов wrote: Hello, is it possible to have a code review for the changes proposed in JDK-8251548? Sean Mullan has created an issue and web-revi

Request for review of JDK-8251548

2020-09-17 Thread Сергей Цыпанов
Hello, is it possible to have a code review for the changes proposed in JDK-8251548? Sean Mullan has created an issue and web-review and can sponsor the patch as soos as it gets properly reviewed. As Doug Lea claims in http://cs.oswego.edu/pipermail/concurrency-interest/2015-December/014770.htm