Re: Request to review JDK-8028094

2013-11-27 Thread Balchandra Vaidya
Hi Martin, I have incorporated your contribution into following webrev. Please review the changes. http://cr.openjdk.java.net/~bvaidya/8/8028094/webrev.01/ I have tested it on a linux machine, and the test is passing. The sleep processes are killed when the pkill command exists on the mach

Re: Request to review JDK-8028094

2013-11-20 Thread Balchandra Vaidya
Thanks Martin. I will incorporate your suggested improvements, and will send out another webrev. Regards Balchandra On 19/11/2013 22:53, Martin Buchholz wrote: I see this is already submitted. I thought I could do better than using pkill, but no - there is no convenient communication from t

Re: Request to review JDK-8028094

2013-11-20 Thread Balchandra Vaidya
Hi Martin, It is just an effort try to cleanup the leftover sleep process before the test terminates. Thanks Balchandra On 19/11/2013 19:44, Martin Buchholz wrote: Is there an actual problem caused by all those sleep processes, or are you just trying to be tidy? On Tue, Nov 19, 2013 at 6

Re: Request to review JDK-8028094

2013-11-20 Thread Balchandra Vaidya
On 19/11/2013 19:42, Martin Buchholz wrote: It would be nice if every request for review included URLs for the bug report (in addition to the webrev). Here is the bug id: https://bugs.openjdk.java.net/browse/JDK-8028094 The existing test has a check for the existence of /bin/sleep before ru

Request to review JDK-8028094

2013-11-19 Thread Balchandra Vaidya
Hi, Here is one possible solution for the issue JDK-8028094. http://cr.openjdk.java.net/~bvaidya/8/8028094/webrev/ I am not sure pkill is available in all Unix flavor at /usr/bin directory, but it is present in Solaris and OEL 6. I have tested on Solaris and OEL and "sleep " is no longe

Re: Request to review JDK-8028094

2013-11-19 Thread Balchandra Vaidya
Thanks Chris. Regards Balchandra On 19/11/2013 14:23, Chris Hegarty wrote: Look ok to me Balchandra. I can sponsor this for you. -Chris. On 11/19/2013 02:07 PM, Balchandra Vaidya wrote: Hi, Here is one possible solution for the issue JDK-8028094. http://cr.openjdk.java.net/~bvaidya/8/80

Re: Request to review JDK-8028094

2013-11-19 Thread Chris Hegarty
Look ok to me Balchandra. I can sponsor this for you. -Chris. On 11/19/2013 02:07 PM, Balchandra Vaidya wrote: Hi, Here is one possible solution for the issue JDK-8028094. http://cr.openjdk.java.net/~bvaidya/8/8028094/webrev/ I am not sure pkill is available in all Unix flavor at /usr/bin di

Request to review JDK-8028094

2013-11-19 Thread Balchandra Vaidya
Hi, Here is one possible solution for the issue JDK-8028094. http://cr.openjdk.java.net/~bvaidya/8/8028094/webrev/ I am not sure pkill is available in all Unix flavor at /usr/bin directory, but it is present in Solaris and OEL 6. I have tested on Solaris and OEL and "sleep " is no longer le