Re: Review Request: CR#8001634 : Initial set of lambda functional interfaces

2012-11-14 Thread Howard Lovatt
General Comment = For the collections framework there is a description of the whole framework (http://docs.oracle.com/javase/7/docs/technotes/guides/collections/index.html); why not do the same for the lambda framework and put a reference to the description in all the interfaces'

Re: Review Request: CR#8001634 : Initial set of lambda functional interfaces

2012-11-01 Thread Alan Bateman
On 31/10/2012 20:16, Mike Duigou wrote: There's a large set of library changes that will be coming with Lambda. We're getting near the end of the runway and there's lots left to do so we want to start the process of getting some of the more stable pieces put back to the JDK8 repositories.

Re: Review Request: CR#8001634 : Initial set of lambda functional interfaces

2012-11-01 Thread David Holmes
Hi Mike, A few small comments: BinaryOperator: Typo: the the --- Block: * @param t an input object - the input object --- typeBinaryOperator * Combines two {@code type} operands of the same type As opposed to two type operands of different type? :) typeMapper explicitly says it is the

Re: Review Request: CR#8001634 : Initial set of lambda functional interfaces

2012-11-01 Thread Remi Forax
On 11/01/2012 10:43 AM, David Holmes wrote: [...] package-info.java * emFunctional interfaces/em provide typing for lambda methods. lambda methods? Do you mean lambda expressions? non-defaulted is a horrible term. Isn't it simply abstract? Seems to me that abstract default should not be

Re: Review Request: CR#8001634 : Initial set of lambda functional interfaces

2012-11-01 Thread Jim Gish
Hi Mike, Just a few minor javadoc suggestions. Otherwise, the meat looks good. Thanks, Jim --- Copyrights - - why do some of the copyrights say 2010, 2011, 2012 ? Is this the correct format?