Re: Review Request: JDK-8220282 Add MethodHandle tests on accessing final fields

2019-04-02 Thread Lance Andersen
Hi Mandy the updates look good. > On Mar 26, 2019, at 10:58 PM, Mandy Chung wrote: > > This is a new version of the patch: > http://cr.openjdk.java.net/~mchung/jdk13/webrevs/8220282/webrev.01 > > I made further clean up to this new test. > > It extends MethodHandlesTest.HasFields class to inc

Re: Review Request: JDK-8220282 Add MethodHandle tests on accessing final fields

2019-03-26 Thread Mandy Chung
This is a new version of the patch: http://cr.openjdk.java.net/~mchung/jdk13/webrevs/8220282/webrev.01 I made further clean up to this new test. It extends MethodHandlesTest.HasFields class to include the test cases for instance final fields.  HasFields is used to test findGetter/findStaticGette

Re: Review Request: JDK-8220282 Add MethodHandle tests on accessing final fields

2019-03-07 Thread Lance Andersen
Looks ok Mandy > On Mar 7, 2019, at 11:10 AM, Mandy Chung wrote: > > This adds the test cases of setter on final fields to ensure no write > access to final fields with the exception on unreflectSetter on Field > of an instance final field whose accessible flag is set once > JDK-8216558 is resolv

Review Request: JDK-8220282 Add MethodHandle tests on accessing final fields

2019-03-07 Thread Mandy Chung
This adds the test cases of setter on final fields to ensure no write access to final fields with the exception on unreflectSetter on Field of an instance final field whose accessible flag is set once JDK-8216558 is resolved. Webrev at: http://cr.openjdk.java.net/~mchung/jdk13/webrevs/8220282/w