Re: Review Request - JDK-4239752: FileSystem should be a platform-specific class to avoid native code

On 25/10/2012 22:26, Dan Xu wrote: Hi, Please review the code change to avoid native codes when creating the FileSystem object, http://cr.openjdk.java.net/~dxu/4239752/webrev/. In the change, the native codes for windows and unix platforms are removed. Instead, corresponding Java codes are

Re: Review Request - JDK-4239752: FileSystem should be a platform-specific class to avoid native code

Looks good to me. You also fixed the new build to include java.io.FileSystem - that's good. Mandy On 10/25/2012 2:26 PM, Dan Xu wrote: Hi, Please review the code change to avoid native codes when creating the FileSystem object, http://cr.openjdk.java.net/~dxu/4239752/webrev/. In the

Review Request - JDK-4239752: FileSystem should be a platform-specific class to avoid native code

Hi, Please review the code change to avoid native codes when creating the FileSystem object, http://cr.openjdk.java.net/~dxu/4239752/webrev/. In the change, the native codes for windows and unix platforms are removed. Instead, corresponding Java codes are added for each platform. Thanks!

Re: Review Request - JDK-4239752: FileSystem should be a platform-specific class to avoid native code

Looks good to me. Jim On 10/25/2012 05:26 PM, Dan Xu wrote: Hi, Please review the code change to avoid native codes when creating the FileSystem object, http://cr.openjdk.java.net/~dxu/4239752/webrev/. In the change, the native codes for windows and unix platforms are removed. Instead,

Re: Review Request - JDK-4239752: FileSystem should be a platform-specific class to avoid native code

Looks good to me. I have to wonder why we ever used a native method to invoke a Java constructor though ??? David On 26/10/2012 7:26 AM, Dan Xu wrote: Hi, Please review the code change to avoid native codes when creating the FileSystem object,