Re: Review Request JDK-8210721: Replace legacy serial exception field with Throwable::cause

2018-09-17 Thread Daniel Fuchs
On 14/09/2018 18:46, mandy chung wrote: Jason also caught this accidental change in a different thread [1] and also suggests to call super.getCause since getCause is not final and may be overridden.  The updated webrev is: http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8210721/webrev.01/

Re: Review Request JDK-8210721: Replace legacy serial exception field with Throwable::cause

2018-09-14 Thread mandy chung
On 9/14/18 4:01 AM, Daniel Fuchs wrote: Hi Mandy, Looks good to me as well. If a JDK 12 exception is deserialized by an earlier version of the JDK, then the deserialized exception will have both its cause field and custom exception field set to the cause (instead of having the cause field

Re: Review Request JDK-8210721: Replace legacy serial exception field with Throwable::cause

2018-09-14 Thread Daniel Fuchs
Hi Mandy, Looks good to me as well. If a JDK 12 exception is deserialized by an earlier version of the JDK, then the deserialized exception will have both its cause field and custom exception field set to the cause (instead of having the cause field null and the custom field carrying the

Re: Review Request JDK-8210721: Replace legacy serial exception field with Throwable::cause

2018-09-13 Thread Lance Andersen
Looks good Mandy... > On Sep 13, 2018, at 2:44 PM, mandy chung wrote: > > A few exception classes such as ExceptionInInitializerError, > InvocationTargetException, > etc were defined prior to the exception chaining facility and provides the > API to get > the cause of the exception. These

Review Request JDK-8210721: Replace legacy serial exception field with Throwable::cause

2018-09-13 Thread mandy chung
A few exception classes such as ExceptionInInitializerError, InvocationTargetException, etc were defined prior to the exception chaining facility and provides the API to get the cause of the exception. These classes keep its legacy serial field e.g. ExceptionInInitializerError::exception to get