+1
Thanks,
David
On 22/10/2019 6:33 am, Brent Christian wrote:
Looks great. -B
On 10/21/19 10:10 AM, Mandy Chung wrote:
>
Thanks. Updated:
/* Register the natives via the static initializer.
*
* The VM will invoke the initPhase1 method to complete the
initialization
Looks great. -B
On 10/21/19 10:10 AM, Mandy Chung wrote:
>
Thanks. Updated:
/* Register the natives via the static initializer.
*
* The VM will invoke the initPhase1 method to complete the initialization
* of this class separate from .
*/
On 10/18/19 2:46 PM,
On 10/20/19 3:50 PM, David Holmes wrote:
On 19/10/2019 10:38 am, Mandy Chung wrote:
thanks. I think "separated from" reads right to me. I will leave it
as is.
I think "separately" or "separate" seems more correct here. And if
we're picking on grammar then it should be "The VM ..." and "of
On 19/10/2019 10:38 am, Mandy Chung wrote:
thanks. I think "separated from" reads right to me. I will leave it as is.
I think "separately" or "separate" seems more correct here. And if we're
picking on grammar then it should be "The VM ..." and "of this class"
rather than "for this class".
thanks. I think "separated from" reads right to me. I will leave it as is.
Mandy
On 10/18/19 2:46 PM, Brent Christian wrote:
Looks fine. You might consider s/separated/separately/ .
-Brent
On 10/18/19 1:56 PM, Mandy Chung wrote:
A trivial doc fix:
diff --git
Looks fine. You might consider s/separated/separately/ .
-Brent
On 10/18/19 1:56 PM, Mandy Chung wrote:
A trivial doc fix:
diff --git a/src/java.base/share/classes/java/lang/System.java
b/src/java.base/share/classes/java/lang/System.java
---
A trivial doc fix:
diff --git a/src/java.base/share/classes/java/lang/System.java
b/src/java.base/share/classes/java/lang/System.java
--- a/src/java.base/share/classes/java/lang/System.java
+++ b/src/java.base/share/classes/java/lang/System.java
@@ -94,10 +94,8 @@
public final class System {