Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

Thanks! On 07.04.2015 20:13, Roger Riggs wrote: Thanks, looks fine. Roger On 4/7/2015 1:00 PM, alexander stepanov wrote: Hello Roger, Thank you for the notes, fixed:

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

Thanks! On 07.04.2015 20:48, Lance Andersen wrote: Hi Alexander, InTypeCode.java you might want to use {@code} vs code so that you do not have to use gt; lt; Otherwise it is OK Best Lance On Apr 7, 2015, at 1:00 PM, alexander stepanov alexander.v.stepa...@oracle.com

Review Request for 8039440: Tidy warnings cleanup for org/omg

Hello, I'm not if the mail list is correct, but could anyone please review the following fix? http://cr.openjdk.java.net/~avstepan/8039440/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8039440 Just an HTML markup fix for CORBA. Thanks, Alexander

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

I'm not sure either but the fix looks OK to me. -yan On 04/07/2015 05:40 PM, alexander stepanov wrote: Hello, I'm not if the mail list is correct, but could anyone please review the following fix? http://cr.openjdk.java.net/~avstepan/8039440/webrev.01/ Bug:

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

Thanks! On 07.04.2015 17:45, Yuri Nesterenko wrote: I'm not sure either but the fix looks OK to me. -yan On 04/07/2015 05:40 PM, alexander stepanov wrote: Hello, I'm not if the mail list is correct, but could anyone please review the following fix?

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

Hi, I'll send some comments in a bit, there are a few things to fix. Roger On 4/7/2015 10:47 AM, alexander stepanov wrote: Thanks! On 07.04.2015 17:45, Yuri Nesterenko wrote: I'm not sure either but the fix looks OK to me. -yan On 04/07/2015 05:40 PM, alexander stepanov wrote: Hello,

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

Hello Roger, Thank you for the notes, fixed: http://cr.openjdk.java.net/~avstepan/8039440/webrev.01/src/java.corba/share/classes/org/omg/CORBA/portable/package.html.udiff.html

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

Hi, Just a few minor comments; no need for another webrev (on my account). The preferred form for code markup is {@code } instead of code... /code and tt... /tt but that may beyond the scope of the current issue. - Lowercase markup p is preferred over uppercase P but per file conventions

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

Hi Alexander, InTypeCode.java you might want to use {@code} vs code so that you do not have to use gt; lt; Otherwise it is OK Best Lance On Apr 7, 2015, at 1:00 PM, alexander stepanov alexander.v.stepa...@oracle.com wrote: Hello Roger, Thank you for the notes, fixed: