Re: Review request: 8154190 & 8155513: Deprivilege java.compiler and jdk.charsets

2016-05-05 Thread Jonathan Gibbons
OK for java.compiler -- Jon On 04/29/2016 10:02 PM, Mandy Chung wrote: JDK-8154190: Deprivilege java.compiler module Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8154190/webrev.00/ JDK-8155513: Deprivilege jdk.charsets module Webrev: http://cr.openjdk.java.net/~mchung/jdk9/we

Re: Review request: 8154190 & 8155513: Deprivilege java.compiler and jdk.charsets

2016-05-04 Thread Alan Bateman
On 03/05/2016 21:16, Mandy Chung wrote: I originally asked Sherman to identify the permissions for jdk.charsets as a follow up issue. I took another look and define the list: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8155513/webrev.01/ This looks okay to me. -Alan.

Re: Review request: 8154190 & 8155513: Deprivilege java.compiler and jdk.charsets

2016-05-03 Thread Mandy Chung
> On Apr 29, 2016, at 11:25 PM, Alan Bateman wrote: > > On 30/04/2016 06:02, Mandy Chung wrote: >> JDK-8154190: Deprivilege java.compiler module >> Webrev: >>http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8154190/webrev.00/ >> >> JDK-8155513: Deprivilege jdk.charsets module >> Webrev: >>

Re: Review request: 8154190 & 8155513: Deprivilege java.compiler and jdk.charsets

2016-04-30 Thread Chris Hegarty
> On 30 Apr 2016, at 06:02, Mandy Chung wrote: > > JDK-8154190: Deprivilege java.compiler module > Webrev: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8154190/webrev.00/ > > JDK-8155513: Deprivilege jdk.charsets module > Webrev: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8155513

Re: Review request: 8154190 & 8155513: Deprivilege java.compiler and jdk.charsets

2016-04-29 Thread Alan Bateman
On 30/04/2016 06:02, Mandy Chung wrote: JDK-8154190: Deprivilege java.compiler module Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8154190/webrev.00/ JDK-8155513: Deprivilege jdk.charsets module Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8155513/webrev.00/ Very si

Review request: 8154190 & 8155513: Deprivilege java.compiler and jdk.charsets

2016-04-29 Thread Mandy Chung
JDK-8154190: Deprivilege java.compiler module Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8154190/webrev.00/ JDK-8155513: Deprivilege jdk.charsets module Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8155513/webrev.00/ Very simple change. These patches move java.compil